-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use alt for render #69
Conversation
hope to see you complete the change and full example |
@transedward I have issues with And there's a problem with resolving promises at rendering, only the top component promises will be resolved. With |
seems like a problem with other library too. |
@transedward I didn't have time to trace the error, I'm working on it :) |
thanks for the hard work, @iam4x |
Will check this out. |
@goatslacker I'm going to try with the new |
Just came across this repo--really nice stuff, and excited to see progress on this and #68! |
@quicksnap Thank's, I replied to you about the current state of next changes in the issue ;) |
LGTM! thx a lot, hope this can merge to master soon |
BTW, A change to rendering in Alt is in progress: goatslacker/alt#364 |
@erkieh Yes I'm waiting for this PR, it will solve some of the issues I'm having right now. |
I think it solves the react router issues you were having |
Yes thank you @goatslacker can't wait for this to be merged, I'm grateful to all of the work you put into Alt 👏 |
<3 sorry it's taking so long. This is quite complex and I want to get it right. |
I've rebased with my changes on master with the new beta of react-router, still stuck :) I'll wait for the new PR to be merged until furthers changes. |
@goatslacker Issue with Waiting for the PR for having nested components promises to be resolved too. |
YUS...I haven't had time to check for myself, thanks for checking. I'll put up a PR today outlining some progress. |
@@ -0,0 +1 @@ | |||
export default (fn) => new Promise((resolve) => fn((result) => resolve(result))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it used yet anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right it's a left over of the rebase, going to remove it. Thanks.
On Sat, 11 Jul 2015 at 15:25 Dmitry Polushkin notifications@github.com
wrote:
In app/utils/promisify.js
#69 (comment)
:@@ -0,0 +1 @@
+export default (fn) => new Promise((resolve) => fn((result) => resolve(result)));Is it used yet anywhere?
—
Reply to this email directly or view it on GitHub
https://github.com/iam4x/isomorphic-flux-boilerplate/pull/69/files#r34412605
.
Btw this is the latest heap of crappy code I wrote to try qnd solve this problem: |
See #68 |
See #68
(Still having issues)