Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use alt for render #69

Closed
wants to merge 12 commits into from
Closed

[WIP] Use alt for render #69

wants to merge 12 commits into from

Conversation

iam4x
Copy link
Owner

@iam4x iam4x commented Jun 4, 2015

See #68

(Still having issues)

@iam4x iam4x self-assigned this Jun 4, 2015
@hungtuchen
Copy link

hope to see you complete the change and full example
@iam4x ++

@iam4x
Copy link
Owner Author

iam4x commented Jun 11, 2015

@transedward I have issues with alt and react-router at page change.

And there's a problem with resolving promises at rendering, only the top component promises will be resolved. With alt-resolver from the boilerplate you can resolve every promises thrown from components.

@hungtuchen
Copy link

only the top component promises will be resolved

seems like a problem with other library too.
any issue reported yet?
and what's the issue about react router?

@iam4x
Copy link
Owner Author

iam4x commented Jun 11, 2015

@transedward I didn't have time to trace the error, I'm working on it :)

@hungtuchen
Copy link

thanks for the hard work, @iam4x

@goatslacker
Copy link

Will check this out.

@iam4x
Copy link
Owner Author

iam4x commented Jun 15, 2015

@goatslacker I'm going to try with the new react-router 1.0 alpha

@quicksnap
Copy link
Contributor

Just came across this repo--really nice stuff, and excited to see progress on this and #68!

@iam4x
Copy link
Owner Author

iam4x commented Jun 18, 2015

@quicksnap Thank's, I replied to you about the current state of next changes in the issue ;)

@filod
Copy link

filod commented Jun 29, 2015

LGTM! thx a lot, hope this can merge to master soon

@erkieh
Copy link

erkieh commented Jun 29, 2015

BTW, A change to rendering in Alt is in progress: goatslacker/alt#364

@iam4x
Copy link
Owner Author

iam4x commented Jun 29, 2015

@erkieh Yes I'm waiting for this PR, it will solve some of the issues I'm having right now.

@goatslacker
Copy link

I think it solves the react router issues you were having

@iam4x
Copy link
Owner Author

iam4x commented Jul 5, 2015

Yes thank you @goatslacker can't wait for this to be merged, I'm grateful to all of the work you put into Alt 👏

@goatslacker
Copy link

<3 sorry it's taking so long. This is quite complex and I want to get it right.

@iam4x iam4x force-pushed the use-alt-for-render branch from 6879f7f to adc77e8 Compare July 9, 2015 14:25
@iam4x
Copy link
Owner Author

iam4x commented Jul 9, 2015

I've rebased with my changes on master with the new beta of react-router, still stuck :)

I'll wait for the new PR to be merged until furthers changes.

@iam4x
Copy link
Owner Author

iam4x commented Jul 9, 2015

@goatslacker Issue with react-router which don't render component on second transition is fixed now with the react-router@1.0-beta3 🎉

Waiting for the PR for having nested components promises to be resolved too.

@goatslacker
Copy link

YUS...I haven't had time to check for myself, thanks for checking.

I'll put up a PR today outlining some progress.

@@ -0,0 +1 @@
export default (fn) => new Promise((resolve) => fn((result) => resolve(result)));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it used yet anywhere?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right it's a left over of the rebase, going to remove it. Thanks.
On Sat, 11 Jul 2015 at 15:25 Dmitry Polushkin notifications@github.com
wrote:

In app/utils/promisify.js
#69 (comment)
:

@@ -0,0 +1 @@
+export default (fn) => new Promise((resolve) => fn((result) => resolve(result)));

Is it used yet anywhere?


Reply to this email directly or view it on GitHub
https://github.com/iam4x/isomorphic-flux-boilerplate/pull/69/files#r34412605
.

@goatslacker
Copy link

Btw this is the latest heap of crappy code I wrote to try qnd solve this problem:

goatslacker/alt#393

@iam4x
Copy link
Owner Author

iam4x commented Nov 16, 2015

See #68

@iam4x iam4x deleted the use-alt-for-render branch December 7, 2015 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants