fix: ensure switching audio/video properly resets analyser

iamDecode · Mar 13, 2021 · b98b779 · b98b779
1 parent 05dcb4c
commit b98b779
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/public/main.js b/public/main.js
@@ -204,13 +204,10 @@ audioInputSelect.onchange = videoSelect.onchange = async (e) => {
   const audioTrack = stream.getAudioTracks()[0];
   const videoTrack = stream.getVideoTracks()[0];
 
+  app.selfPlayer.stream = stream;
+  app.playStream(stream, app.selfPlayer);
   app.selfPlayer.analyser = null;
 
-  if (e.target.id == 'videoSource') {
-    app.selfPlayer.stream = stream;
-    playStream(stream, app.selfPlayer);
-  }
-
   app.mediasoupClient.producerTransport.handler._pc.getSenders().forEach((s) => {
     if (s.track.kind == videoTrack.kind) {
       console.log('replacing video!');

diff --git a/public/player.js b/public/player.js
@@ -54,6 +54,10 @@ export class Player {
   }
 
   addVideo(element) {
+    if (this.$video != null) {
+      this.$video.remove();
+    }
+
     this.$video = element;
     this.$elem.appendChild(element);
   }