Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use partial variant as default export #141

Merged
merged 6 commits into from
Sep 6, 2022
Merged

use partial variant as default export #141

merged 6 commits into from
Sep 6, 2022

Conversation

iambumblehead
Copy link
Owner

@iambumblehead iambumblehead commented Sep 5, 2022 •
edited
Loading

  • update sources and tests to use partial variant as default export,
  • update readme,
  • remove esmock.partial and partial export definitions to reduce typescript maintenance burden
  • resolve error when using partial mocking with modules not found on filesystem

@iambumblehead
Copy link
Owner Author

I intend to post a draft of the release notes w/ migration steps here later

@iambumblehead
Copy link
Owner Author

please review

aladdin-add
aladdin-add approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@iambumblehead
Copy link
Owner Author

closes #121

@iambumblehead iambumblehead merged commit 302ca82 into master Sep 6, 2022
@iambumblehead iambumblehead deleted the use-partial-variant-as-default-export branch September 6, 2022 15:50
@iambumblehead iambumblehead mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

@tripodsan tripodsan tripodsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iambumblehead @tripodsan @aladdin-add @bumblehead