Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wrapper and main compile functions #96

Merged
merged 4 commits into from
Jul 25, 2020

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

Refactor the wrapper and main compiler functions.

Closes #53
Closes #80

How I did it

  • simplify the wrapper logic to accept any keyword argument as a string, int, tuple, list, bool
  • use specific kwargs for compile_source, compile_files, compile_standard
  • extract output types for combined_json by calling solc --help

How to verify it

Run tests.

I haven't yet added new tests - prior to the actual v1.0.0 release this will be handled, but for now I'm still refactoring and so it feels premature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant