Skip to content

Commit

Permalink
Adds windows configuration to VS code tasks (isaac-sim#963)
Browse files Browse the repository at this point in the history
# Description

Currently, the tasks shipped with the VS code configuration only specify
Linux commands, which prevent the use of them on Windows. This MR adds
those tasks for Windows OS as well.

Fixes isaac-sim#962

## Type of change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
  • Loading branch information
johnBuffer authored Sep 11, 2024
1 parent a78c419 commit 78b1ad7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
"type": "shell",
"linux": {
"command": "${workspaceFolder}/isaaclab.sh -p ${workspaceFolder}/.vscode/tools/setup_vscode.py"
},
"windows": {
"command": "${workspaceFolder}/isaaclab.bat -p ${workspaceFolder}/.vscode/tools/setup_vscode.py"
}
},
{
Expand All @@ -17,6 +20,9 @@
"type": "shell",
"linux": {
"command": "${workspaceFolder}/isaaclab.sh --format"
},
"windows": {
"command": "${workspaceFolder}/isaaclab.bat --format"
}
}
]
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Guidelines for modifications:
* Chenyu Yang
* David Yang
* HoJin Jeon
* Jean Tampon
* Jia Lin Yuan
* Jingzhou Liu
* Johnson Sun
Expand Down

0 comments on commit 78b1ad7

Please sign in to comment.