Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bundle size #209

Closed
wants to merge 12 commits into from
Closed

Reduce bundle size #209

wants to merge 12 commits into from

Conversation

merceyz
Copy link

@merceyz merceyz commented Dec 21, 2019

Related issues
Closes #163

Changes

Result
Bundled with rollup, excluding externals

Before 23,9 KB (24 540 bytes)
After 19,5 KB (20 050 bytes)

@iamhosseindhv
Copy link
Owner

Outdated PR. Propbably a new one takes less time than resolving conflicts on this. Thanks for your contribution @merceyz

@merceyz
Copy link
Author

merceyz commented May 8, 2020

I would have had to resolve them anyways, so I did, you can re-open the PR 👍

@iamhosseindhv iamhosseindhv reopened this May 8, 2020
@iamhosseindhv
Copy link
Owner

Thanks @merceyz appreciate it a lot. Happy to merge.

Can you share the setup you use to measure bundle size? (last time you mentioned rollup)
I'd like to add the repo, so from now on we can see the effect of each bit of code being added/removed.

@iamhosseindhv
Copy link
Owner

iamhosseindhv commented May 15, 2020

Fixed in #268 using a third party library.

Huge thanks @merceyz for your contribution. Would be my pleasure to have you in contributors list, if you could make a PR with a dummy commit.

@merceyz merceyz deleted the bundle-size branch May 15, 2020 17:55
@merceyz
Copy link
Author

merceyz commented May 15, 2020

Fixed in #268 using a third party library.

Great, less code to maintain!

Would be my pleasure to have you in contributors list, if you could make a PR with a dummy commit.

Thank you but that's not necessary 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Huge file size
2 participants