Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react-is dependency #272

Merged
merged 3 commits into from
May 17, 2020
Merged

Remove react-is dependency #272

merged 3 commits into from
May 17, 2020

Conversation

iamhosseindhv
Copy link
Owner

No description provided.

@iamhosseindhv iamhosseindhv merged commit d73be98 into master May 17, 2020
@iamhosseindhv iamhosseindhv deleted the dump-react-is branch May 17, 2020 16:09
@oliviertassinari
Copy link
Contributor

oliviertassinari commented May 18, 2020

react-is has a high adoption rate in the react community. I think that removing it and inlining the helpers:

  • forces to use React internals, which can break
  • increase bundle size in the application as the logic can no longer be deduplicated

@oliviertassinari
Copy link
Contributor

oliviertassinari commented May 18, 2020

One alternative is to use

import { getDisplayName } from '@material-ui/utils';

it shouldn't be used in production anyway, I would hope it's tree shaked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants