Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 427 #429

Closed
wants to merge 3 commits into from
Closed

Fix 427 #429

wants to merge 3 commits into from

Conversation

aress31
Copy link

@aress31 aress31 commented Sep 16, 2021

This PR is aimed to address ticket #427 by implementing a better integration with the Material UI theme.

Question to @iamhosseindhv, do you prefer using the main or light theme variant for normal/light theme. I went with main as IMHO it is bright enough for a light theme and provides a sufficient contrast ratio.

I also replaced the hardcoded padding values with theme.spacing(n) so that global changes to a theme are directly reflected in the snackbar.

Note: This PR is based off the next branch for support with MUI v5.

@aress31 aress31 changed the base branch from master to next September 16, 2021 18:51
@iamhosseindhv iamhosseindhv deleted the branch iamhosseindhv:next September 26, 2021 15:27
@iamhosseindhv
Copy link
Owner

Hey @aress31 , This pr was automatically closed because next branch is deleted. See #437 .

Notistack used to be tightly coupled with mui and use the theme object, but in favour of #421 and #184 we are not using the theme object anymore.

That doesn't mean you can't use mui theme or support dark theme yourself. Using notistack v3 (which is still in alpha), you can have custom components for each variant:

https://codesandbox.io/s/cold-brook-gsubs?file=/src/index.js

@iamhosseindhv iamhosseindhv mentioned this pull request Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants