-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locale Contributions Wanted 🙋🙏 #171
Comments
ping @ohbarye, and seems you've already done it. Bravo! |
I'm working on the ./docs/ Brazilian Portuguese translation! @iamkun Is it OK to slightly modify some of the docs' wording to fit the translation? Depending on the language, some parts are pretty awkward to translate 100%. |
@ludvon
Of course. It's up to you. But better keep the document's structure the same, so that I could update them easily if there is some small changes like API name or agreements change. |
We could convert the momentjs locales to the dayjs format. I tried it automatically and it worked for most of them (there are some languages which require additional information for month name handling and the ordinal function), but we could use all others as a basis. @iamkun what do you think? |
@KorbinianKuhn Thanks, this should work, but little copycat I think. |
@iamkun for the fromNow plugin to work, I think the relativeTime variable should also be added to the locale template? Right now it is implemented on the spanish locale and the default english one, e.g
WDYT? |
I'll update this to the I18n docs after finishing the plugin. |
Hi @iamkun, I try to add translation for Indonesian Language, but i don't know how to open pull request cz locales folder ignored by .gitignore file. And then how to test if my translation is working? 😄 Thank you |
@muhibbudins Hi, just open a new PR, and what's the problem now? If your translation could pass our auto CI test, then it should be fine. |
Hi @iamkun , I still can't open new PR. Because my local change is not detected 😃 On your .gitignore file you have code like this :
So my new file on src/locale/id.js not detected on git change stage. Note : I'm already fork your repo to my account 😄 Thank you |
@muhibbudins The Maybe you could try remove the line in |
Thanks, I've updated the |
Korean locale!! iamkun#171
```js dayjs('2000-10-25') .set('month', 3) .set('year', 2020).toString(); // Sat, 25 Apr 2020 00:00:00 GMT ``` to ```js dayjs('2000-10-25') .set('month', 3) .set('year', 2020).toString(); // Sat, 25 Mar 2020 00:00:00 GMT ```
At the moment The same as Moment.js Issue 422 |
@MartinDawson Are you mean |
@iamkun If I supply de-DE then it's obvious I want de locale. The library doesn't support de-DE so it makes sense to me to fall back to de. |
@MartinDawson Well, seems not hard. All we have to do is to supply a helper function isn't it? dayjs.locale(helper('de-DE')) // helper will return 'de' |
It is impossible to contribute correct Slavic localisations for the RelativeTime plugin of Day.js. It is possible for Moment.js, but for the price of overriding the whole |
Release 1.6.2 was just published to the NPM with I18n support. Thanks again, everyone, for helping with this effort.
Day.js users come from all around the world, so I will happily accept translations from other languages for this project. And your work will affect thousands of daily users of Day.js.
Feel free to open a pull request if you've finished one of the three translations.
Locale (I18n)
Locale is the first translation work we need to do, and it will be released with our main code.
Locale template
Readme file
Readme file let user get a glance of our project. And tells them what we are doing.
If there is no sub pages' translation, please keep the links in readme linked to English sub pages.
Add a link to your translation in the default english readme file.
Default English Readme
Sub pages of the document
Sub pages is the detailed documents of our project.
NOTE: It is welcome to put your language in the first place in locale example in files such as
I18n.md
.e.g. for Japanese docs
Sub pages folder
Directory structure
Please place the translation files in a separate folder, and named with ISO 639-1 area code. Directory structure could be found below.
Finally, thanks again for your contribution.
Append:
We use ISO 639-2 country code.
Check lists short codes for language here or here
The text was updated successfully, but these errors were encountered: