Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update RelativeTime plugin default config #883

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Fix: Update RelativeTime plugin default config #883

merged 2 commits into from
Apr 26, 2020

Conversation

zerooverture
Copy link
Contributor

if require('dayjs/locale/en')
instance.$locale().relativeTime is undefined

Loc in fromTo is undefined
The loc[t.l] throws an error: Cannot read property 'xx' of undefined

if  require('dayjs/locale/en')
instance.$locale().relativeTime is undefined
@zerooverture zerooverture changed the title Update index.js Update relativeTime Apr 26, 2020
@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #883 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #883   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       164           
  Lines         1330      1331    +1     
  Branches       276       277    +1     
=========================================
+ Hits          1330      1331    +1     
Impacted Files Coverage Δ
src/plugin/relativeTime/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcea067...e668c76. Read the comment docs.

@iamkun iamkun changed the title Update relativeTime Fix: Update RelativeTime plugin default config Apr 26, 2020
@iamkun iamkun merged commit 0606f42 into iamkun:dev Apr 26, 2020
@iamkun
Copy link
Owner

iamkun commented Apr 26, 2020

THX

iamkun pushed a commit that referenced this pull request Apr 30, 2020
## [1.8.26](v1.8.25...v1.8.26) (2020-04-30)

### Bug Fixes

* Fix Duration plugin `.toISOString` format bug ([#889](#889)) ([058d624](058d624)), closes [#888](#888)
* Fix WeekOfYear plugin bug while using BadMutable plugin ([#884](#884)) ([2977438](2977438))
* Update CustomParseFormat plugin strict mode ([#882](#882)) ([db642ac](db642ac))
* Update RelativeTime plugin default config ([#883](#883)) ([0606f42](0606f42))
@iamkun
Copy link
Owner

iamkun commented Apr 30, 2020

🎉 This PR is included in version 1.8.26 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.26](iamkun/dayjs@v1.8.25...v1.8.26) (2020-04-30)

### Bug Fixes

* Fix Duration plugin `.toISOString` format bug ([#889](iamkun/dayjs#889)) ([058d624](iamkun/dayjs@058d624)), closes [#888](iamkun/dayjs#888)
* Fix WeekOfYear plugin bug while using BadMutable plugin ([#884](iamkun/dayjs#884)) ([2977438](iamkun/dayjs@2977438))
* Update CustomParseFormat plugin strict mode ([#882](iamkun/dayjs#882)) ([db642ac](iamkun/dayjs@db642ac))
* Update RelativeTime plugin default config ([#883](iamkun/dayjs#883)) ([0606f42](iamkun/dayjs@0606f42))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.26](iamkun/dayjs@v1.8.25...v1.8.26) (2020-04-30)

### Bug Fixes

* Fix Duration plugin `.toISOString` format bug ([#889](iamkun/dayjs#889)) ([058d624](iamkun/dayjs@058d624)), closes [#888](iamkun/dayjs#888)
* Fix WeekOfYear plugin bug while using BadMutable plugin ([#884](iamkun/dayjs#884)) ([2977438](iamkun/dayjs@2977438))
* Update CustomParseFormat plugin strict mode ([#882](iamkun/dayjs#882)) ([db642ac](iamkun/dayjs@db642ac))
* Update RelativeTime plugin default config ([#883](iamkun/dayjs#883)) ([0606f42](iamkun/dayjs@0606f42))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
## [1.8.26](iamkun/dayjs@v1.8.25...v1.8.26) (2020-04-30)

### Bug Fixes

* Fix Duration plugin `.toISOString` format bug ([#889](iamkun/dayjs#889)) ([058d624](iamkun/dayjs@058d624)), closes [#888](iamkun/dayjs#888)
* Fix WeekOfYear plugin bug while using BadMutable plugin ([#884](iamkun/dayjs#884)) ([2977438](iamkun/dayjs@2977438))
* Update CustomParseFormat plugin strict mode ([#882](iamkun/dayjs#882)) ([db642ac](iamkun/dayjs@db642ac))
* Update RelativeTime plugin default config ([#883](iamkun/dayjs#883)) ([0606f42](iamkun/dayjs@0606f42))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants