Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update CustomParseFormat plugin strict mode #882

Merged
merged 3 commits into from
Apr 27, 2020
Merged

fix: Update CustomParseFormat plugin strict mode #882

merged 3 commits into from
Apr 27, 2020

Conversation

iamkun
Copy link
Owner

@iamkun iamkun commented Apr 26, 2020 •
edited
Loading

fix #881

@codecov
Copy link

codecov bot commented Apr 26, 2020 •
edited
Loading

Codecov Report

Merging #882 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #882   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       164           
  Lines         1330      1340   +10     
  Branches       276       280    +4     
=========================================
+ Hits          1330      1340   +10
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/plugin/customParseFormat/index.js 100.00% <100.00%> (ø)
src/plugin/utc/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcea067...a0fe358. Read the comment docs.

@iamkun iamkun merged commit db642ac into dev Apr 27, 2020
@dagda1 dagda1 mentioned this pull request Apr 29, 2020
Closed
@iamkun iamkun deleted the customParseFormat-update branch April 30, 2020 04:04
iamkun pushed a commit that referenced this pull request Apr 30, 2020
@semantic-release-bot
chore(release): 1.8.26 [skip ci]
c95be8a 
## [1.8.26](v1.8.25...v1.8.26) (2020-04-30)

### Bug Fixes

* Fix Duration plugin `.toISOString` format bug ([#889](#889)) ([058d624](058d624)), closes [#888](#888)
* Fix WeekOfYear plugin bug while using BadMutable plugin ([#884](#884)) ([2977438](2977438))
* Update CustomParseFormat plugin strict mode ([#882](#882)) ([db642ac](db642ac))
* Update RelativeTime plugin default config ([#883](#883)) ([0606f42](0606f42))
@iamkun
Copy link
Owner Author

iamkun commented Apr 30, 2020

🎉 This PR is included in version 1.8.26 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.26 [skip ci]
3521b65 
## [1.8.26](iamkun/dayjs@v1.8.25...v1.8.26) (2020-04-30)

### Bug Fixes

* Fix Duration plugin `.toISOString` format bug ([#889](iamkun/dayjs#889)) ([058d624](iamkun/dayjs@058d624)), closes [#888](iamkun/dayjs#888)
* Fix WeekOfYear plugin bug while using BadMutable plugin ([#884](iamkun/dayjs#884)) ([2977438](iamkun/dayjs@2977438))
* Update CustomParseFormat plugin strict mode ([#882](iamkun/dayjs#882)) ([db642ac](iamkun/dayjs@db642ac))
* Update RelativeTime plugin default config ([#883](iamkun/dayjs#883)) ([0606f42](iamkun/dayjs@0606f42))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.26 [skip ci]
b1183a8 
## [1.8.26](iamkun/dayjs@v1.8.25...v1.8.26) (2020-04-30)

### Bug Fixes

* Fix Duration plugin `.toISOString` format bug ([#889](iamkun/dayjs#889)) ([058d624](iamkun/dayjs@058d624)), closes [#888](iamkun/dayjs#888)
* Fix WeekOfYear plugin bug while using BadMutable plugin ([#884](iamkun/dayjs#884)) ([2977438](iamkun/dayjs@2977438))
* Update CustomParseFormat plugin strict mode ([#882](iamkun/dayjs#882)) ([db642ac](iamkun/dayjs@db642ac))
* Update RelativeTime plugin default config ([#883](iamkun/dayjs#883)) ([0606f42](iamkun/dayjs@0606f42))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
@semantic-release-bot
chore(release): 1.8.26 [skip ci]
16f6bdc 
## [1.8.26](iamkun/dayjs@v1.8.25...v1.8.26) (2020-04-30)

### Bug Fixes

* Fix Duration plugin `.toISOString` format bug ([#889](iamkun/dayjs#889)) ([058d624](iamkun/dayjs@058d624)), closes [#888](iamkun/dayjs#888)
* Fix WeekOfYear plugin bug while using BadMutable plugin ([#884](iamkun/dayjs#884)) ([2977438](iamkun/dayjs@2977438))
* Update CustomParseFormat plugin strict mode ([#882](iamkun/dayjs#882)) ([db642ac](iamkun/dayjs@db642ac))
* Update RelativeTime plugin default config ([#883](iamkun/dayjs#883)) ([0606f42](iamkun/dayjs@0606f42))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistencies where 0 is involved when initialising from a string
1 participant
@iamkun