Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix DayOfYear plugin when using BadMutable plugin #1511

Merged
merged 1 commit into from
Jun 1, 2021
Merged

fix: Fix DayOfYear plugin when using BadMutable plugin #1511

merged 1 commit into from
Jun 1, 2021

Conversation

seanyeh
Copy link
Contributor

@seanyeh seanyeh commented May 30, 2021

Fixes #1407
Very similar to a previous fix for WeekOfYear: #884

To reproduce:

var badMutable = require('dayjs/plugin/badMutable');
var dayOfYear = require('dayjs/plugin/dayOfYear');

dayjs.extend(badMutable);
dayjs.extend(dayOfYear);
dayjs('02.25.2020').dayOfYear(); // Should return 56, but returns 1 instead

@codecov
Copy link

codecov bot commented May 30, 2021 •
edited
Loading

Codecov Report

Merging #1511 (48b42b8) into dev (06f88f4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1511   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          176       176           
  Lines         1965      1965           
  Branches       497       497           
=========================================
  Hits          1965      1965
Impacted Files Coverage Δ
src/plugin/dayOfYear/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f88f4...48b42b8. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Jun 1, 2021

Thanks

@iamkun iamkun merged commit 0b0c6a3 into iamkun:dev Jun 1, 2021
iamkun pushed a commit that referenced this pull request Jul 6, 2021
@semantic-release-bot
chore(release): 1.10.6 [skip ci]
42e494b 
## [1.10.6](v1.10.5...v1.10.6) (2021-07-06)

### Bug Fixes

* add invalid date string override ([#1465](#1465)) ([#1470](#1470)) ([06f88f4](06f88f4))
* add sv-fi Finland Swedish locale ([#1522](#1522)) ([8e32164](8e32164))
* customParseFormat support parsing X x timestamp ([#1567](#1567)) ([eb087f5](eb087f5))
* dayjs ConfigTypeMap add null & undefined ([#1560](#1560)) ([b5e40e6](b5e40e6))
* Fix DayOfYear plugin when using BadMutable plugin ([#1511](#1511)) ([0b0c6a3](0b0c6a3))
* Implement ordinal in Bulgarian translation (fixes [#1501](#1501)) ([#1502](#1502)) ([b728da5](b728da5))
* more strict delimiter in REGEX_PARSE ([#1555](#1555)) ([bfdab5c](bfdab5c))
* parameter type ([#1549](#1549)) ([f369844](f369844))
* update customParseFormat plugin to custom two-digit year parse function ([#1421](#1421)) ([bb5df55](bb5df55))
* update names of weekdays and months in Bulgarian [bg] to lowercase ([#1438](#1438)) ([b246210](b246210))
* update type file `.diff` ([#1505](#1505)) ([6508494](6508494))
* update UTC plugin type file for strict parsing ([#1443](#1443)) ([b4f28df](b4f28df))
@iamkun
Copy link
Owner

iamkun commented Jul 6, 2021

🎉 This PR is included in version 1.10.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jul 6, 2021
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.10.6 [skip ci]
ff72724 
## [1.10.6](iamkun/dayjs@v1.10.5...v1.10.6) (2021-07-06)

### Bug Fixes

* add invalid date string override ([#1465](iamkun/dayjs#1465)) ([#1470](iamkun/dayjs#1470)) ([06f88f4](iamkun/dayjs@06f88f4))
* add sv-fi Finland Swedish locale ([#1522](iamkun/dayjs#1522)) ([8e32164](iamkun/dayjs@8e32164))
* customParseFormat support parsing X x timestamp ([#1567](iamkun/dayjs#1567)) ([eb087f5](iamkun/dayjs@eb087f5))
* dayjs ConfigTypeMap add null & undefined ([#1560](iamkun/dayjs#1560)) ([b5e40e6](iamkun/dayjs@b5e40e6))
* Fix DayOfYear plugin when using BadMutable plugin ([#1511](iamkun/dayjs#1511)) ([0b0c6a3](iamkun/dayjs@0b0c6a3))
* Implement ordinal in Bulgarian translation (fixes [#1501](iamkun/dayjs#1501)) ([#1502](iamkun/dayjs#1502)) ([b728da5](iamkun/dayjs@b728da5))
* more strict delimiter in REGEX_PARSE ([#1555](iamkun/dayjs#1555)) ([bfdab5c](iamkun/dayjs@bfdab5c))
* parameter type ([#1549](iamkun/dayjs#1549)) ([f369844](iamkun/dayjs@f369844))
* update customParseFormat plugin to custom two-digit year parse function ([#1421](iamkun/dayjs#1421)) ([bb5df55](iamkun/dayjs@bb5df55))
* update names of weekdays and months in Bulgarian [bg] to lowercase ([#1438](iamkun/dayjs#1438)) ([b246210](iamkun/dayjs@b246210))
* update type file `.diff` ([#1505](iamkun/dayjs#1505)) ([6508494](iamkun/dayjs@6508494))
* update UTC plugin type file for strict parsing ([#1443](iamkun/dayjs#1443)) ([b4f28df](iamkun/dayjs@b4f28df))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.10.6 [skip ci]
3798db5 
## [1.10.6](iamkun/dayjs@v1.10.5...v1.10.6) (2021-07-06)

### Bug Fixes

* add invalid date string override ([#1465](iamkun/dayjs#1465)) ([#1470](iamkun/dayjs#1470)) ([06f88f4](iamkun/dayjs@06f88f4))
* add sv-fi Finland Swedish locale ([#1522](iamkun/dayjs#1522)) ([8e32164](iamkun/dayjs@8e32164))
* customParseFormat support parsing X x timestamp ([#1567](iamkun/dayjs#1567)) ([eb087f5](iamkun/dayjs@eb087f5))
* dayjs ConfigTypeMap add null & undefined ([#1560](iamkun/dayjs#1560)) ([b5e40e6](iamkun/dayjs@b5e40e6))
* Fix DayOfYear plugin when using BadMutable plugin ([#1511](iamkun/dayjs#1511)) ([0b0c6a3](iamkun/dayjs@0b0c6a3))
* Implement ordinal in Bulgarian translation (fixes [#1501](iamkun/dayjs#1501)) ([#1502](iamkun/dayjs#1502)) ([b728da5](iamkun/dayjs@b728da5))
* more strict delimiter in REGEX_PARSE ([#1555](iamkun/dayjs#1555)) ([bfdab5c](iamkun/dayjs@bfdab5c))
* parameter type ([#1549](iamkun/dayjs#1549)) ([f369844](iamkun/dayjs@f369844))
* update customParseFormat plugin to custom two-digit year parse function ([#1421](iamkun/dayjs#1421)) ([bb5df55](iamkun/dayjs@bb5df55))
* update names of weekdays and months in Bulgarian [bg] to lowercase ([#1438](iamkun/dayjs#1438)) ([b246210](iamkun/dayjs@b246210))
* update type file `.diff` ([#1505](iamkun/dayjs#1505)) ([6508494](iamkun/dayjs@6508494))
* update UTC plugin type file for strict parsing ([#1443](iamkun/dayjs#1443)) ([b4f28df](iamkun/dayjs@b4f28df))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
@semantic-release-bot
chore(release): 1.10.6 [skip ci]
799551a 
## [1.10.6](iamkun/dayjs@v1.10.5...v1.10.6) (2021-07-06)

### Bug Fixes

* add invalid date string override ([#1465](iamkun/dayjs#1465)) ([#1470](iamkun/dayjs#1470)) ([06f88f4](iamkun/dayjs@06f88f4))
* add sv-fi Finland Swedish locale ([#1522](iamkun/dayjs#1522)) ([8e32164](iamkun/dayjs@8e32164))
* customParseFormat support parsing X x timestamp ([#1567](iamkun/dayjs#1567)) ([eb087f5](iamkun/dayjs@eb087f5))
* dayjs ConfigTypeMap add null & undefined ([#1560](iamkun/dayjs#1560)) ([b5e40e6](iamkun/dayjs@b5e40e6))
* Fix DayOfYear plugin when using BadMutable plugin ([#1511](iamkun/dayjs#1511)) ([0b0c6a3](iamkun/dayjs@0b0c6a3))
* Implement ordinal in Bulgarian translation (fixes [#1501](iamkun/dayjs#1501)) ([#1502](iamkun/dayjs#1502)) ([b728da5](iamkun/dayjs@b728da5))
* more strict delimiter in REGEX_PARSE ([#1555](iamkun/dayjs#1555)) ([bfdab5c](iamkun/dayjs@bfdab5c))
* parameter type ([#1549](iamkun/dayjs#1549)) ([f369844](iamkun/dayjs@f369844))
* update customParseFormat plugin to custom two-digit year parse function ([#1421](iamkun/dayjs#1421)) ([bb5df55](iamkun/dayjs@bb5df55))
* update names of weekdays and months in Bulgarian [bg] to lowercase ([#1438](iamkun/dayjs#1438)) ([b246210](iamkun/dayjs@b246210))
* update type file `.diff` ([#1505](iamkun/dayjs#1505)) ([6508494](iamkun/dayjs@6508494))
* update UTC plugin type file for strict parsing ([#1443](iamkun/dayjs#1443)) ([b4f28df](iamkun/dayjs@b4f28df))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dayOfYear produces incorrect results
2 participants
@seanyeh @iamkun