Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed utc.valueOf not taking DST into account #1815

Closed
wants to merge 1 commit into from

Conversation

SkaceKamen
Copy link

Use the current date to determine internal timezone offset instead of using a new Date instance, since the new Date returns a different offset based on whenever DST is in effect at the moment.

This PR fixes #1804

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1815 (b88a359) into dev (c7a3f73) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #1815   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          180       180           
  Lines         2033      2034    +1     
  Branches       523       524    +1     
=========================================
+ Hits          2033      2034    +1     
Impacted Files Coverage Δ
src/plugin/utc/index.js 100.00% <100.00%> (ø)
src/locale/gl.js 100.00% <0.00%> (ø)
src/locale/ku.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a3f73...b88a359. Read the comment docs.

@xvaara
Copy link
Contributor

xvaara commented Mar 19, 2022

this is same as #1448
but since it's a year old and not merged (even though it's a big problem), one has to wonder where to focus of this project is.

@iamkun
Copy link
Owner

iamkun commented May 3, 2022

Thanks, fixed in #1448

@iamkun iamkun closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utc.valueOf doesn't account for DST correctly
3 participants