Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct past property in KU (kurdish) locale #1916

Merged
merged 1 commit into from
Jun 15, 2022
Merged

fix: correct past property in KU (kurdish) locale #1916

merged 1 commit into from
Jun 15, 2022

Conversation

mahamaad
Copy link
Contributor

hello dayjs, in this pr add value to past property in english say ago say in kurdish say something like لەمەوپێش

thank you.

@iamkun
Copy link
Owner

iamkun commented Jun 4, 2022

Should we keep the same with moment.js translation? https://github.com/moment/moment/blob/develop/src/locale/ku.js#L86

@mahamaad
Copy link
Contributor Author

mahamaad commented Jun 4, 2022

We need to change it in moment.js too

@iamkun
Copy link
Owner

iamkun commented Jun 4, 2022

alright, thanks. Could you ask another native speaker to review this PR before it gets merged?

@mahamaad
Copy link
Contributor Author

mahamaad commented Jun 4, 2022

Sure

@mahamaad
Copy link
Contributor Author

mahamaad commented Jun 4, 2022

@hariiad @roj1512, Please can you review it?

@rojvv
Copy link

rojvv commented Jun 4, 2022 •
edited
Loading

There is a serious problem: The code ku must not be used for Central Kurdish.

rojvv
rojvv approved these changes Jun 4, 2022
View reviewed changes
Copy link

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much!

@CYAXXX
Copy link

CYAXXX commented Jun 4, 2022

Ku isn't for Sorani guys, Come on!

@rojvv
Copy link

rojvv commented Jun 4, 2022

@CYAXXX I'll make a PR to fix that after this is merged. This is just a typo fix.

@iamkun
Copy link
Owner

iamkun commented Jun 8, 2022

@mahamaad I did not really get your conversation. Is this PR a correct fix on ku.js, or should we move it to another file?

@mahamaad
Copy link
Contributor Author

mahamaad commented Jun 8, 2022

@mahamaad I did not really get your conversation. Is this PR a correct fix on ku.js, or should we move it to another file?

Yeah this pr correct fix past property u can approve it,
but in fact, because Kurdish have two dialects, Sorani and Kurmanji, which have the most speakers, we need to rename the file from ku to Kurdish Sorani. We can rename it in this pr or make another pr which do you prefer?

@rojvv
Copy link

rojvv commented Jun 8, 2022

@iamkun Here's it:

  • You just merge this and done.

We'll take care of the rest.

@iamkun
Copy link
Owner

iamkun commented Jun 15, 2022 •
edited
Loading

Cool, I'll merge this first. Thanks.

@iamkun iamkun merged commit 74e82b9 into iamkun:dev Jun 15, 2022
iamkun pushed a commit that referenced this pull request Jul 19, 2022
@semantic-release-bot
chore(release): 1.11.4 [skip ci]
fdf648b 
## [1.11.4](v1.11.3...v1.11.4) (2022-07-19)

### Bug Fixes

* correct past property in ku (kurdish) locale ([#1916](#1916)) ([74e82b9](74e82b9))
* fix French [fr] local ordinal ([#1932](#1932)) ([8f09834](8f09834))
* fix objectSupport plugin ConfigTypeMap type ([#1441](#1441)) ([#1990](#1990)) ([fd51fe4](fd51fe4))
* fix type error to add ordianl property in InstanceLocaleDataReturn and GlobalLocaleDataReturn types ([#1931](#1931)) ([526f0ae](526f0ae))
* update locale ar-* meridiem function ([#1954](#1954)) ([3d31611](3d31611))
* zh-tw / zh-hk locale ordinal error ([#1976](#1976)) ([0a1bd08](0a1bd08))
@iamkun
Copy link
Owner

iamkun commented Jul 19, 2022

🎉 This PR is included in version 1.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

BePo65 pushed a commit to BePo65/dayjs that referenced this pull request Aug 6, 2022
@semantic-release-bot @BePo65
chore(release): 1.11.4 [skip ci]
f7096c6 
## [1.11.4](iamkun/dayjs@v1.11.3...v1.11.4) (2022-07-19)

### Bug Fixes

* correct past property in ku (kurdish) locale ([iamkun#1916](iamkun#1916)) ([74e82b9](iamkun@74e82b9))
* fix French [fr] local ordinal ([iamkun#1932](iamkun#1932)) ([8f09834](iamkun@8f09834))
* fix objectSupport plugin ConfigTypeMap type ([iamkun#1441](iamkun#1441)) ([iamkun#1990](iamkun#1990)) ([fd51fe4](iamkun@fd51fe4))
* fix type error to add ordianl property in InstanceLocaleDataReturn and GlobalLocaleDataReturn types ([iamkun#1931](iamkun#1931)) ([526f0ae](iamkun@526f0ae))
* update locale ar-* meridiem function ([iamkun#1954](iamkun#1954)) ([3d31611](iamkun@3d31611))
* zh-tw / zh-hk locale ordinal error ([iamkun#1976](iamkun#1976)) ([0a1bd08](iamkun@0a1bd08))
@mdfkbtc mdfkbtc mentioned this pull request May 19, 2024
Open
@NOUIY NOUIY mentioned this pull request May 20, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request May 20, 2024
Open
@NOUIY NOUIY mentioned this pull request May 24, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request May 24, 2024
Open
@B0ub0 B0ub0 mentioned this pull request Jun 8, 2024
Open
@OATEF4313 OATEF4313 mentioned this pull request Jun 20, 2024
Open
@mdfkbtc mdfkbtc mentioned this pull request Jun 21, 2024
Open
@swayangjit swayangjit mentioned this pull request Jul 11, 2024
Open
@Z-byte-prog Z-byte-prog mentioned this pull request Jul 17, 2024
Closed
@marinabs23 marinabs23 mentioned this pull request Jul 30, 2024
Open
@otmaneEH otmaneEH mentioned this pull request Jul 30, 2024
Open
This was referenced Jul 31, 2024
Open
Open
Open
Open
@FlorentinTh FlorentinTh mentioned this pull request Aug 9, 2024
Open
@mdfkbtc mdfkbtc mentioned this pull request Aug 9, 2024
Open
@marinabs23 marinabs23 mentioned this pull request Aug 9, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
@flon-chou flon-chou mentioned this pull request Aug 15, 2024
Open
@NOUIY NOUIY mentioned this pull request Aug 21, 2024
Open
@lcf262412 lcf262412 mentioned this pull request Sep 9, 2024
Open
@marinabs23 marinabs23 mentioned this pull request Sep 12, 2024
Open
@organich organich mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 14, 2024
Open
Open
This was referenced Sep 15, 2024
Open
Open
@takawiramundure takawiramundure mentioned this pull request Sep 17, 2024
Open
@organich organich mentioned this pull request Sep 17, 2024
Open
This was referenced Sep 18, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request Sep 23, 2024
Open
@mdfkbtc mdfkbtc mentioned this pull request Sep 24, 2024
Open
@Z-byte-prog Z-byte-prog mentioned this pull request Sep 28, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request Sep 29, 2024
Open
@KaliforniaShell KaliforniaShell mentioned this pull request Oct 2, 2024
Merged
@FlorentinTh FlorentinTh mentioned this pull request Oct 22, 2024
Open
@Jekyle9444 Jekyle9444 mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rojvv rojvv rojvv approved these changes

Assignees
No one assigned
Labels
Need Review released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahamaad @iamkun @rojvv @CYAXXX