-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct past property in KU (kurdish) locale #1916
Conversation
Should we keep the same with moment.js translation? https://github.com/moment/moment/blob/develop/src/locale/ku.js#L86 |
We need to change it in moment.js too |
alright, thanks. Could you ask another native speaker to review this PR before it gets merged? |
Sure |
There is a serious problem: The code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you so much!
Ku isn't for Sorani guys, Come on! |
@CYAXXX I'll make a PR to fix that after this is merged. This is just a typo fix. |
@mahamaad I did not really get your conversation. Is this PR a correct fix on ku.js, or should we move it to another file? |
Yeah this pr correct fix past property u can approve it, |
@iamkun Here's it:
We'll take care of the rest. |
Cool, I'll merge this first. Thanks. |
## [1.11.4](v1.11.3...v1.11.4) (2022-07-19) ### Bug Fixes * correct past property in ku (kurdish) locale ([#1916](#1916)) ([74e82b9](74e82b9)) * fix French [fr] local ordinal ([#1932](#1932)) ([8f09834](8f09834)) * fix objectSupport plugin ConfigTypeMap type ([#1441](#1441)) ([#1990](#1990)) ([fd51fe4](fd51fe4)) * fix type error to add ordianl property in InstanceLocaleDataReturn and GlobalLocaleDataReturn types ([#1931](#1931)) ([526f0ae](526f0ae)) * update locale ar-* meridiem function ([#1954](#1954)) ([3d31611](3d31611)) * zh-tw / zh-hk locale ordinal error ([#1976](#1976)) ([0a1bd08](0a1bd08))
🎉 This PR is included in version 1.11.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [1.11.4](iamkun/dayjs@v1.11.3...v1.11.4) (2022-07-19) ### Bug Fixes * correct past property in ku (kurdish) locale ([iamkun#1916](iamkun#1916)) ([74e82b9](iamkun@74e82b9)) * fix French [fr] local ordinal ([iamkun#1932](iamkun#1932)) ([8f09834](iamkun@8f09834)) * fix objectSupport plugin ConfigTypeMap type ([iamkun#1441](iamkun#1441)) ([iamkun#1990](iamkun#1990)) ([fd51fe4](iamkun@fd51fe4)) * fix type error to add ordianl property in InstanceLocaleDataReturn and GlobalLocaleDataReturn types ([iamkun#1931](iamkun#1931)) ([526f0ae](iamkun@526f0ae)) * update locale ar-* meridiem function ([iamkun#1954](iamkun#1954)) ([3d31611](iamkun@3d31611)) * zh-tw / zh-hk locale ordinal error ([iamkun#1976](iamkun#1976)) ([0a1bd08](iamkun@0a1bd08))
hello dayjs, in this pr add value to past property in english say ago say in kurdish say something like لەمەوپێش
thank you.