fix: update fa locale

[Soheil-Saberi]

update translate month ,monthsShort , weekdaysShort and relativeTime.past

[iamkun]

we use https://github.com/moment/moment/blob/develop/src/locale/fa.js as a reference, can you please tell us why such a difference between the two?

[codecov]

Codecov Report

Merging #2151 (f0982d9) into dev (cbe91fd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #2151   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          183       183           
  Lines         2096      2096           
  Branches       550       549    -1     
=========================================
  Hits          2096      2096           

Impacted Files	Coverage Δ
src/locale/fa.js	100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Soheil-Saberi]

Hi iamkun Firstly, thank you for paying attention to this issue and emphasizing the importance of accurate translations based on location. The common calendar of Persian speakers and people of Iran is the Jalali calendar. The order of the months of the Jalali calendar is as follows : | No | Month (Persian Language) | Month (English Language) | 1 | فروردین | Farvardin | 2 | اردیبهشت | Ordibehesht | 3. | خرداد | Khordad | 4 | تیر | Tir | 5 | مرداد | Mordad | 6 | شهریور | Shahrivar | 7 | مهر | Mehr | 8 | آبان | Aban | 9 | آذر | Azar | 10 | دی | Dey | 11 | بهمن | Bahman | 12 | اسفند | Esfand Click here for more details <https://en.wikipedia.org/wiki/Iranian_calendars> Most libraries and frameworks use the dayjs library (for example, in the DatePicker of the Mantain library <https://mantine.dev/dates/date-picker/>). Because of this problem, programmers were forced to develop side libraries from the dayjs library (for example, dayjs-jalali <https://github.com/torbatian/dayjs-jalali> , jalaliday <https://github.com/alibaba-aero/jalaliday>) ,moment.js library has exactly the same problem (Persian example : moment-jalaali <https://github.com/jalaali/moment-jalaali>). For these reasons, I requested to change the Farsi translation

…

On Sat, Dec 3, 2022 at 4:32 PM iamkun ***@***.***> wrote: we use https://github.com/moment/moment/blob/develop/src/locale/fa.js as a reference, can you please tell us why such a difference between the two? — Reply to this email directly, view it on GitHub <#2151 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFJ4WMWPS37HEO434WSXUKLWLNAE7ANCNFSM6AAAAAASRXU2JQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[iamkun]

Thanks for the details above.

I'm afraid I can't decide whether to merge this or not since it has a lot of differences from the original moment's locale.

I'll label this pr and wait for more reviews from your native speakers.

[Soheil-Saberi]

Thank you for paying attention to this issue
Additionally, I share this issue with Farsi language developers to contribute to its improvement

[cnaez]

I am agree with Soheil.
We need some changes to make dayjs better for Iranian developers.
Thank you guys

[iamkun]

Cheers

[iamkun]

🎉 This PR is included in version 1.11.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[raminjafary]

@iamkun @Soheil-Saberi This PR is getting it wrong by simply translating locale months to Solar Hijri calendar but not taking care of solar calendar's date and time transformations. Dayjs' locale provides literal translations of the Gregory calendar's months which is correct. I believe this PR should be reverted to avoid confusions and misunderstanding.

I suggest to use this plugin for Persian users. It handles all the date-time logic of solar calendar along with correct names of the months.
https://github.com/alibaba-aero/jalaliday

[Soheil-Saberi]

hi @raminjafary
This PR has been posted before, you will understand with a more detailed examination of the dayjs library and the usage of the local file.
By checking the local files of other countries in dayjs and their calendars, you can understand this issue

[raminjafary]

Most of the countries do not have solar calendar. As a result, they have one to one mapping of English [literal] translations for the months. But, If you use solar (Persian) months, you have to use solar calendar date-time, too.

[Soheil-Saberi]

@raminjafary
Not all countries use the Gregorian calendar, so check the local file of other countries.
Read this link for more information about different calendars.

[raminjafary]

There is no guarantee that the other locale files of the other countries in Dayjs repo is being approved context wise.
Dayjs is neither a solar nor lunar system based calendar so it doesn't make sense to provide translations of any other calendar system as is without the necessary date time modifications.
For example, As of my experience, January which is يناير in ar-IQ locale is just a Gregorian equivalent with the same date time system. Although the first day of the week is different, it is configurable via Dayjs locale plugin.

[Soheil-Saberi]

@raminjafary
If you check all the methods of the Dayjs library, you will notice the use of the locale method.
All methods in the Dayjs library do not perform date conversions.
These locale files of the Dayjs library are mostly references of other libraries for the use of its translation, for example, in library Mantine for Dates, when the locale library Dayjs is called, only the names of the months are taken(link mantain/dates)
You can see examples of these use cases in other libraries that use Dayjs.

[amirhmoradi]

Hi everyone.
I agree with @raminjafary on the fact that when using a calendar system the locale object shall provide the correct names of that calendar system and not another calendar system.
i.e.
if using Gregorian calendar,
-> month names shall be in Gregorian calendar month in all languages:
----> fr: Janvier, en: January, fa: ژانویه

if using Persian calendar (shamsi/jalalli),
-> month names shall be in Persian calendar month in all languages:
----> fr: Ordibehešt, en: Ordibehesht, fa: اردیبهشت

It does not make sense, neither it is useable from a user's use-case point of view, to translate the NAME of first month of the Gregorian calendar to the NAME of first month of another calendar without converting dates.

The #2151 PR is not correct in this matter. A new PR is required to fix the fa locale.

To solve the issue around calendar systems with dayjs, I have created a new plugin that allows using multiple non-gregorian calendars and does correct conversions. Have a look here: https://github.com/calidy-com/dayjs-calendarsystems

Also, my plugin does an override on the fa locale to fix the currently running inconsistency in month names.

[mokhosh]

What an irresponsible PR!
This change is based on a wrong plugin architecture where the OP doesn't try to handle generation of month names in the plugin, rather he changes the original month names regardless of what calendar system dayjs is using.

This needs to be reverted asap.

Related: alibaba-aero/jalaliday#39

[raminjafary]

@iamkun FYI

[raminjafary]

I opened a PR to undo these changes. @mokhosh @amirhmoradi It would be great if I could have your comments or confirmations on this PR #2411.

[github-actions]

🎉 This issue has been resolved in version 1.11.10 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀