Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Norwegian Bokmål "nb" locale. #250

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Conversation

ariselseng
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 22, 2018

Codecov Report

Merging #250 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #250   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     28    +1     
  Lines         362    365    +3     
  Branches       52     52           
=====================================
+ Hits          362    365    +3
Impacted Files Coverage Δ
src/locale/nb.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857e6bc...00cbd8d. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Jun 22, 2018

@cowai thanks cool

@iamkun iamkun merged commit 7f13ae1 into iamkun:master Jun 22, 2018
@ariselseng
Copy link
Contributor Author

@iamkun Wow that was fast!
Looking forward for this to be available in a release.

@iamkun
Copy link
Owner

iamkun commented Jun 22, 2018

@cowai Will be available in next release.

Plus, according to other libs, weekdaysShort in Norwegian "nb" locale is not the first three letters. Any update here?

@ariselseng
Copy link
Contributor Author

@iamkun Thanks.
Both first 2 and 3 works in Norwegian.
I wondered what I should take but ended up doing the same as Swedish and Danish (90% same language) is in this project: https://github.com/iamkun/dayjs/blob/master/src/locale/da.js and https://github.com/iamkun/dayjs/blob/master/src/locale/sv.js

@ariselseng
Copy link
Contributor Author

@iamkun Oh, I misunderstood you at first.
Yes, all weekdays in Norwegian can absolutely be cut to use only first 2 and 3 letters.

@iamkun
Copy link
Owner

iamkun commented Jun 22, 2018

@cowai It's up to you, native speaker 😬.

@iamkun
Copy link
Owner

iamkun commented Jun 25, 2018

🎉 This PR is included in version 1.6.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants