Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix GitHub release failed with status: 403 #282

Merged
merged 1 commit into from
Feb 5, 2023
Merged

fix: fix GitHub release failed with status: 403 #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/pull-request-cleanup-manual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ concurrency:
group: ${{ github.workflow }}
cancel-in-progress: false

permissions:
contents: write
packages: write

env:
PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
PULL_REQUEST_BRANCH: ${{ github.head_ref }}
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/pull-request-cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ env:
PACKAGE_TYPE: container
USERNAME: ${{ github.repository_owner }}

permissions:
contents: write
packages: write

jobs:
cleanup-ghcr:
runs-on: ubuntu-latest
Expand Down
38 changes: 28 additions & 10 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
deploy-sign-docker-image: ${{ fromJson(steps.config.outputs.config).deploy.sign-docker-image }}
deploy-pre-release-matrix: ${{ steps.pre-release-matrix.outputs.matrix }}
deploy-release-matrix: ${{ steps.release-matrix.outputs.matrix }}
is-forked: ${{ github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name }}
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down Expand Up @@ -149,6 +150,8 @@ jobs:

release:
runs-on: ubuntu-latest
permissions:
contents: write
needs:
- config
- build
Expand All @@ -175,6 +178,7 @@ jobs:
run: mv application.tar.gz ${{ github.event.repository.name }}.tar.gz

- name: Create release
if: ${{ env.FORKED == 'false' }}
uses: softprops/action-gh-release@v1
id: create-release
with:
Expand All @@ -190,6 +194,10 @@ jobs:

deploy:
name: deploy-[${{ matrix.name }}]
permissions:
contents: write
packages: write
pull-requests: write
runs-on: ubuntu-latest
strategy:
max-parallel: 1
Expand Down Expand Up @@ -224,28 +232,33 @@ jobs:
make oci.pc download-rpms

- name: Build image
id: docker-meta
env:
VERSION: "${{ needs.release.outputs.version }}"
run: make ${{ matrix.name }}-image
run: |
make ${{ matrix.name }}-image
TAG_SUFFIX=$(echo "-${{ matrix.name }}" | sed s/-ubuntu//)
echo "image-id=$IMAGE_NAME" >> $GITHUB_OUTPUT
echo "image-version=${VERSION}${TAG_SUFFIX}" >> $GITHUB_OUTPUT

- name: Log in to registry
if: ${{ env.FORKED == 'false' }}
run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ${{ env.REGISTRY }} -u $ --password-stdin

- name: Push image
id: docker-meta
if: ${{ env.FORKED == 'false' }}
env:
VERSION: "${{ needs.release.outputs.version }}"
run: |
make push-${{ matrix.name }}-image
TAG_SUFFIX=$(echo "-${{ matrix.name }}" | sed s/-ubuntu//)
echo "image-id=$IMAGE_NAME" >> $GITHUB_OUTPUT
echo "image-version=${VERSION}${TAG_SUFFIX}" >> $GITHUB_OUTPUT

- name: Format current time
if: ${{ env.FORKED == 'false' }}
id: time_now
run: echo "time_now_formatted=$(date +'%Y-%m-%d %H:%M:%S')" >> "$GITHUB_OUTPUT"

- name: Find releases comment
if: ${{ env.FORKED == 'false' }}
uses: peter-evans/find-comment@v2
id: find_comment
with:
Expand All @@ -255,7 +268,7 @@ jobs:

- name: Create releases comment
uses: peter-evans/create-or-update-comment@v2
if: ${{ steps.find_comment.outputs.comment-id == '' }}
if: ${{ steps.find_comment.outputs.comment-id == '' && env.FORKED == 'false' }}
with:
comment-id: ${{ steps.find_comment.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
Expand All @@ -269,7 +282,7 @@ jobs:

- name: Append releases comment
uses: peter-evans/create-or-update-comment@v2
if: ${{ steps.find_comment.outputs.comment-id != '' }}
if: ${{ steps.find_comment.outputs.comment-id != '' && env.FORKED == 'false' }}
with:
comment-id: ${{ steps.find_comment.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
Expand All @@ -278,16 +291,16 @@ jobs:
| ${{ steps.time_now.outputs.time_now_formatted }} | **${{ steps.docker-meta.outputs.image-version }}** |

- name: Setup cosign
if: ${{ needs.config.outputs.deploy-sign-docker-image == 'true' }}
if: ${{ needs.config.outputs.deploy-sign-docker-image == 'true' && env.FORKED == 'false' }}
uses: sigstore/cosign-installer@main

- name: Write signing key to disk (only needed for `cosign sign --key`)
if: ${{ needs.config.outputs.deploy-sign-docker-image == 'true' }}
if: ${{ needs.config.outputs.deploy-sign-docker-image == 'true' && env.FORKED == 'false' }}
continue-on-error: true
run: echo "${{ secrets.SIGNING_SECRET }}" > cosign.key

- name: Sign the published Docker image
if: ${{ needs.config.outputs.deploy-sign-docker-image == 'true' }}
if: ${{ needs.config.outputs.deploy-sign-docker-image == 'true' && env.FORKED == 'false' }}
continue-on-error: true
env:
COSIGN_PASSWORD: ""
Expand All @@ -314,7 +327,12 @@ jobs:

comments:
runs-on: ubuntu-latest
if: ${{ needs.config.outputs.is-forked == 'false' }}
permissions:
contents: write
pull-requests: write
needs:
- config
- release
steps:
- name: Format current time
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:

jobs:
config:
if: github.triggering_actor != 'dependabot[bot]'
if: github.triggering_actor != 'dependabot[bot]' && github.event.pull_request.merged == true
runs-on: ubuntu-latest
outputs:
go-version: ${{ fromJson(steps.config.outputs.config).go-version }}
Expand Down Expand Up @@ -206,22 +206,23 @@ jobs:
make oci.pc download-rpms

- name: Build image
id: docker-meta
env:
VERSION: "${{ needs.release.outputs.version }}"
run: make ${{ matrix.name }}-image
run: |
make ${{ matrix.name }}-image
TAG_SUFFIX=$(echo "-${{ matrix.name }}" | sed s/-ubuntu//)
echo "image-id=$IMAGE_NAME" >> $GITHUB_OUTPUT
echo "image-version=${VERSION}${TAG_SUFFIX}" >> $GITHUB_OUTPUT

- name: Log in to registry
run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ${{ env.REGISTRY }} -u $ --password-stdin

- name: Push image
id: docker-meta
env:
VERSION: "${{ needs.release.outputs.version }}"
run: |
make push-${{ matrix.name }}-image
TAG_SUFFIX=$(echo "-${{ matrix.name }}" | sed s/-ubuntu//)
echo "image-id=$IMAGE_NAME" >> $GITHUB_OUTPUT
echo "image-version=${VERSION}${TAG_SUFFIX}" >> $GITHUB_OUTPUT

- name: Setup cosign
if: ${{ needs.config.outputs.deploy-sign-docker-image == 'true' }}
Expand Down