Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Feature request: expand airbnb's list of files for import/no-extraneous-dependencies to include TS files #121

Closed
Martyniuk opened this issue Aug 3, 2020 · 3 comments · Fixed by #190
Labels

Comments

@Martyniuk
Copy link

Martyniuk commented Aug 3, 2020

When importing packages into config files written in TS (eg, webpack.config.ts), an error will be reported claiming webpack should be a dependency, not a dev dependency

Screenshot 2020-08-03 at 16 50 01

In the spirit of airbnb's config for import/no-extraneous-dependencies, it would be great for eslint-config-airbnb-typescript to extend that list to also include TS files.

version of:
"eslint-config-airbnb-typescript": "^8.0.2",

@Martyniuk Martyniuk changed the title Issue with "import/no-extraneous-dependencies" in non-src folder for ".ts" files Feature request: expand airbnb's list of files for import/no-extraneous-dependencies to include TS files Aug 4, 2020
@aryzing
Copy link

aryzing commented Aug 4, 2020

That would be amazing, I need this too. Ran into this issue myself today.

@Martyniuk
Copy link
Author

Martyniuk commented Aug 5, 2020

You've already have support of requested feature, possibly there is some mistake from my side. Gonna close it for now.

Screenshot 2020-08-05 at 10 20 42

matt-tingen added a commit to matt-tingen/eslint-config-airbnb-typescript that referenced this issue Nov 7, 2020
Several config files such as `webpack.js` are not listed as `{js,jsx}`.

Fixes iamturns#121
@iamturns
Copy link
Owner

iamturns commented Feb 6, 2021

🎉 This issue has been resolved in version 12.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants