This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 101
V16.1.1 throw error for return await within a try-catch block. #280
Labels
Comments
Thanks @steven-g-w - good catch. Your proposed changes make sense to me. A PR would be great, if you're keen! |
🎉 This issue has been resolved in version 16.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this issue
Mar 23, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint-config-airbnb-typescript](https://github.com/iamturns/eslint-config-airbnb-typescript) | devDependencies | patch | [`16.1.2` -> `16.1.4`](https://renovatebot.com/diffs/npm/eslint-config-airbnb-typescript/16.1.2/16.1.4) | --- ### Release Notes <details> <summary>iamturns/eslint-config-airbnb-typescript</summary> ### [`v16.1.4`](https://github.com/iamturns/eslint-config-airbnb-typescript/releases/v16.1.4) [Compare Source](iamturns/eslint-config-airbnb-typescript@v16.1.3...v16.1.4) ##### Bug Fixes - disable additional rules handled by TypeScript compiler ([#​283](iamturns/eslint-config-airbnb-typescript#283)) ([11185a9](iamturns/eslint-config-airbnb-typescript@11185a9)) ### [`v16.1.3`](https://github.com/iamturns/eslint-config-airbnb-typescript/releases/v16.1.3) [Compare Source](iamturns/eslint-config-airbnb-typescript@v16.1.2...v16.1.3) ##### Bug Fixes - allow `return await` in `try-catch` block ([#​282](iamturns/eslint-config-airbnb-typescript#282)) ([221be43](iamturns/eslint-config-airbnb-typescript@221be43)), closes [#​280](iamturns/eslint-config-airbnb-typescript#280) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: 6543 <6543@noreply.codeberg.org> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1230 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
version 16.1.1 will throw error for
return await
within a try-catch block.Above code will fail lint check, and even gets auto fixed by removing the
await
if runlint --fix
, which will change the error handling behaviour.This can be fixed by changing the rule to:
I'm happy to create a PR if we agree on that change.
The text was updated successfully, but these errors were encountered: