Skip to content

Fix pre-commit hook failures in k8s azure overlay files #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianlintner merged 2 commits into from
Dec 3, 2025
Merged

Fix pre-commit hook failures in k8s azure overlay files #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7dad56
Initial plan
Copilot Dec 2, 2025
a0056b9
Fix trailing whitespace and end-of-file issues in k8s azure overlay f…
Copilot Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions k8s/overlays/azure/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This directory contains Istio configuration to enable OAuth2 authentication for

- **Application**: python-dsa
- **Namespace**: default
- **Hostnames**:
- **Hostnames**:
- `dsa.cat-herding.net` (primary)
- `dsa.hugecat.net` (legacy)
- **Port**: 80 (routes to container port 5000)
Expand Down Expand Up @@ -264,13 +264,13 @@ data:
service: oauth2-proxy.default.svc.cluster.local
port: 4180
includeHeadersInCheck: ["authorization", "cookie"]
headersToUpstreamOnAllow:
headersToUpstreamOnAllow:
- "authorization"
- "path"
- "x-auth-request-user"
- "x-auth-request-email"
- "x-auth-request-preferred-username"
headersToDownstreamOnDeny:
headersToDownstreamOnDeny:
- "content-type"
- "set-cookie"
headersToDownstreamOnAllow:
Expand Down
6 changes: 3 additions & 3 deletions k8s/overlays/azure/authorization-policy-ext-authz.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ spec:
selector:
matchLabels:
app: python-dsa

# CUSTOM action defers to ext_authz (oauth2-proxy)
action: CUSTOM

provider:
# References the oauth2-proxy extensionProvider configured in Istio mesh config
name: oauth2-proxy

rules:
# Apply to all requests
- to:
Expand Down
1 change: 0 additions & 1 deletion k8s/overlays/azure/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@ resources:
- virtualservice-default.yaml
- virtualservice-hugecat-redirect.yaml
- authorization-policy-ext-authz.yaml

1 change: 0 additions & 1 deletion k8s/overlays/azure/virtualservice-default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,3 @@ spec:
attempts: 3
perTryTimeout: 10s
retryOn: gateway-error,connect-failure,refused-stream

Loading