Introduce Cone3d shape #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rm
force-pushed
the
cone3d
branch
2 times, most recently
from
4232317 to
f013ab2
Compare
|
I think this API looks good! |
|
@ianmackenzie thanks for the review! I will work on the tests tomorrow. Let me know if you have any ideas, otherwise I will base them on the existing cylinder tests. |
|
No particular test ideas off the top of my head, but if I think of anything I'll let you know =) |
|
@ianmackenzie I ported a couple tests from cylinder. Let me know if anything is missing in this PR! |
ianmackenzie
reviewed
May 2, 2020
|
I think this looks good now! I like the tests =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial take on the
Cone3dshape. This is mostly copied fromCylinder3dwith some modifications:endCap, and renamedstartCaptobasecenteredOnandcenterPointrevesrsebasePlaneI wonder if the API is OK, then I can work on some tests.