Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3:CreateBucket not being detected #81

Open
fmartingr opened this issue Sep 5, 2024 · 2 comments
Open

s3:CreateBucket not being detected #81

fmartingr opened this issue Sep 5, 2024 · 2 comments

Comments

@fmartingr
Copy link

fmartingr commented Sep 5, 2024

While running iamlive checking some things I noticed that even when I create a bucket the s3:CreateBucket permission is not being added to the list.

Checking the sample data, it seems that the request check is wrong:

Expects (source):

PUT /{BucketName}

Documentation (source):

PUT / HTTP/1.1
Host: {{BucketName}}.s3.amazonaws.com

Documentation later mentions "URI parameters" (though it hyperlinks to the Host) but doesn't show up like that in the example. Wondering if someone else is experiencing this.

@iann0036
Copy link
Owner

iann0036 commented Sep 6, 2024

Hey @fmartingr,

Thanks for raising!

This helped me find a parsing logic flaw in my implementation. I've now fixed this and this should now work as expected in the next release.

@fmartingr
Copy link
Author

Awesome, thank you for taking care of it that quick! Really appreciated :)

tmeijn pushed a commit to tmeijn/dotfiles that referenced this issue Sep 21, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [iann0036/iamlive](https://github.com/iann0036/iamlive) | patch | `v1.1.10` -> `v1.1.11` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>iann0036/iamlive (iann0036/iamlive)</summary>

### [`v1.1.11`](https://github.com/iann0036/iamlive/releases/tag/v1.1.11)

[Compare Source](iann0036/iamlive@v1.1.10...v1.1.11)

#### Changelog

-   [`4581c2c`](iann0036/iamlive@4581c2c) Fix for s3:CreateBucket not being detected [#&#8203;81](iann0036/iamlive#81)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants