fix NiObjectNET::AddExtraData

ianpatt · Feb 22, 2025 · 3fc89c5 · 3fc89c5
1 parent 9843a23
commit 3fc89c5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/skse64/NiObjects.cpp b/skse64/NiObjects.cpp
@@ -29,7 +29,11 @@ void NiRefObject::DecRef(void)
 
 int ExtraDataCompare(const void * ls, const void * rs)
 {
-	return (int)((*(NiExtraData**)ls)->m_pcName - (*(NiExtraData**)rs)->m_pcName);
+	auto lhs = (*(NiExtraData**)ls)->m_pcName;
+	auto rhs = (*(NiExtraData**)rs)->m_pcName;
+
+	// difference truncated to an int loses important bits
+	return (lhs > rhs) - (lhs < rhs);
 }
 
 void NiObjectNET::AddExtraData(NiExtraData * extraData)

diff --git a/skse64_whatsnew.txt b/skse64_whatsnew.txt
@@ -1,5 +1,6 @@
 2.2.7
 - don't spam OnCrosshairRefChange when player controls are disabled (thanks ferarri365 for the bug report)
+- NiObjectNET::AddExtraData could misorder the list (function not used by SKSE itself, thanks UaineMazoku for the bug report)
 
 2.2.6
 - support for 1.6.1170