fixes a problem importing into some enviroments (jest) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianprime0509
approved these changes
Jul 30, 2022
There was a problem hiding this comment.
Thank you for this! This is good to know. When I originally used import here, I was assuming that would make sense because this library is ESM-only and so it doesn't make sense to require it, but it seems like default should also be fine: https://nodejs.org/api/packages.html#conditional-exports
|
🎉 This PR is included in version 4.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ianprime0509
added a commit
to ianprime0509/temperament
that referenced
this pull request
Aug 6, 2022
package.json should be exported to support certain tools: ianprime0509/pitchy#108 The `default` export condition should be preferred to just using `import`, also to support certain tools: ianprime0509/pitchy#112
ianprime0509
added a commit
to ianprime0509/temperament
that referenced
this pull request
Aug 6, 2022
package.json should be exported to support certain tools: ianprime0509/pitchy#108 The `default` export condition should be preferred to just using `import`, also to support certain tools: ianprime0509/pitchy#112
ianprime0509
added a commit
to ianprime0509/static-jsx
that referenced
this pull request
Aug 6, 2022
package.json should be exported to support certain tools: ianprime0509/pitchy#108 The `default` export condition should be preferred to just using `import`, also to support certain tools: ianprime0509/pitchy#112
ianprime0509
added a commit
to ianprime0509/static-jsx
that referenced
this pull request
Aug 6, 2022
package.json should be exported to support certain tools: ianprime0509/pitchy#108 The `default` export condition should be preferred to just using `import`, also to support certain tools: ianprime0509/pitchy#112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apologies for my previous pull request. i made the wrong change. this one works.
the issue has been detailed here.