Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added character start to fn call arguments per issue #8 #9

Merged
merged 3 commits into from
Nov 22, 2016
Merged

Added character start to fn call arguments per issue #8 #9

merged 3 commits into from
Nov 22, 2016

Conversation

pejrak
Copy link
Contributor

@pejrak pejrak commented Nov 22, 2016 •
edited
Loading

Resolves issue #8.

  • add variables to track current text segment start and length in order for callback to pass the start of matched segment in text
  • added test
  • added offset definition to readme

@iansinnott iansinnott merged commit 0cc751d into iansinnott:master Nov 22, 2016
@iansinnott
Copy link
Owner

Awesome! Thanks @pejrak 👏

@iansinnott
Copy link
Owner

And thanks for updating the readme too. Great PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pejrak @iansinnott