Immer 9 security update (#4505)

* add yarn upgrade-interactive plugin

* chore(immer): update immer to address security issue

* Add changeset

.changeset/sharp-moose-explode.md

@@ -0,0 +1,5 @@
+---
+'slate': patch
+---
+
+Immer 9 security update, refactor to support immer 9 API changes

.yarnrc.yml

@@ -9,4 +9,8 @@ packageExtensions:
     dependencies:
       prop-types: "*"
 
+plugins:
+  - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
+    spec: "@yarnpkg/plugin-interactive-tools"
+
 yarnPath: .yarn/releases/yarn-3.0.1.cjs

packages/slate/package.json

@@ -14,7 +14,7 @@
     "dist/"
   ],
   "dependencies": {
-    "immer": "^8.0.1",
+    "immer": "^9.0.6",
     "is-plain-object": "^5.0.0",
     "tiny-warning": "^1.0.3"
   },

packages/slate/src/interfaces/path.ts

@@ -344,18 +344,22 @@ export const Path: PathInterface = {
    */
 
   transform(
-    path: Path,
+    path: Path | null,
     operation: Operation,
     options: { affinity?: 'forward' | 'backward' | null } = {}
   ): Path | null {
     return produce(path, p => {
       const { affinity = 'forward' } = options
 
       // PERF: Exit early if the operation is guaranteed not to have an effect.
-      if (path.length === 0) {
+      if (!path || path?.length === 0) {
         return
       }
 
+      if (p === null) {
+        return null
+      }
+
       switch (operation.type) {
         case 'insert_node': {
           const { path: op } = operation

packages/slate/src/interfaces/point.ts

@@ -91,11 +91,14 @@ export const Point: PointInterface = {
    */
 
   transform(
-    point: Point,
+    point: Point | null,
     op: Operation,
     options: { affinity?: 'forward' | 'backward' | null } = {}
   ): Point | null {
     return produce(point, p => {
+      if (p === null) {
+        return null
+      }
       const { affinity = 'forward' } = options
       const { path, offset } = p
 

packages/slate/src/interfaces/range.ts

@@ -207,38 +207,40 @@ export const Range: RangeInterface = {
    */
 
   transform(
-    range: Range,
+    range: Range | null,
     op: Operation,
     options: {
       affinity?: 'forward' | 'backward' | 'outward' | 'inward' | null
     } = {}
   ): Range | null {
-    const { affinity = 'inward' } = options
-    let affinityAnchor: 'forward' | 'backward' | null
-    let affinityFocus: 'forward' | 'backward' | null
-
-    if (affinity === 'inward') {
-      if (Range.isForward(range)) {
-        affinityAnchor = 'forward'
-        affinityFocus = 'backward'
-      } else {
-        affinityAnchor = 'backward'
-        affinityFocus = 'forward'
+    return produce(range, r => {
+      if (r === null) {
+        return null
       }
-    } else if (affinity === 'outward') {
-      if (Range.isForward(range)) {
-        affinityAnchor = 'backward'
-        affinityFocus = 'forward'
+      const { affinity = 'inward' } = options
+      let affinityAnchor: 'forward' | 'backward' | null
+      let affinityFocus: 'forward' | 'backward' | null
+
+      if (affinity === 'inward') {
+        if (Range.isForward(r)) {
+          affinityAnchor = 'forward'
+          affinityFocus = 'backward'
+        } else {
+          affinityAnchor = 'backward'
+          affinityFocus = 'forward'
+        }
+      } else if (affinity === 'outward') {
+        if (Range.isForward(r)) {
+          affinityAnchor = 'backward'
+          affinityFocus = 'forward'
+        } else {
+          affinityAnchor = 'forward'
+          affinityFocus = 'backward'
+        }
       } else {
-        affinityAnchor = 'forward'
-        affinityFocus = 'backward'
+        affinityAnchor = affinity
+        affinityFocus = affinity
       }
-    } else {
-      affinityAnchor = affinity
-      affinityFocus = affinity
-    }
-
-    return produce(range, r => {
       const anchor = Point.transform(r.anchor, op, { affinity: affinityAnchor })
       const focus = Point.transform(r.focus, op, { affinity: affinityFocus })
 

yarn.lock

@@ -8591,10 +8591,10 @@ __metadata:
   languageName: node
   linkType: hard
 
-"immer@npm:^8.0.1":
-  version: 8.0.4
-  resolution: "immer@npm:8.0.4"
-  checksum: 9d3b28df1ac5bf6918c611e71c15bdb136588c21a3431100448f21325fef9b055cc9a44fe8b023f0c5ecbc66a2ba38f403c9a67d581f613b49d0e4ff15564f79
+"immer@npm:^9.0.6":
+  version: 9.0.6
+  resolution: "immer@npm:9.0.6"
+  checksum: 75da22f3b32f3f14604eb389b4f50e84a14f2e42f306f0cbe4d2969aed54ec7fda9a7e9ca42ebae2ba73ec9bb6ec1001fafbac535accaf03860054ab0f7e8388
   languageName: node
   linkType: hard
 
@@ -14445,7 +14445,7 @@ resolve@^2.0.0-next.3:
   resolution: "slate@workspace:packages/slate"
   dependencies:
     "@babel/runtime": ^7.7.4
-    immer: ^8.0.1
+    immer: ^9.0.6
     is-plain-object: ^5.0.0
     lodash: ^4.17.21
     slate-hyperscript: ^0.62.0