Capture element selections (#4338)

ianstormtaylor · Jul 6, 2021 · d3d6c51 · d3d6c51
1 parent 51bfb40
commit d3d6c51
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/packages/slate-react/src/components/element.tsx b/packages/slate-react/src/components/element.tsx
@@ -131,11 +131,7 @@ const Element = (props: {
     }
   })
 
-  return (
-    <SelectedContext.Provider value={!!selection}>
-      {renderElement({ attributes, children, element })}
-    </SelectedContext.Provider>
-  )
+  return renderElement({ attributes, children, element })
 }
 
 const MemoizedElement = React.memo(Element, (prev, next) => {

diff --git a/packages/slate-react/src/hooks/use-children.tsx b/packages/slate-react/src/hooks/use-children.tsx
@@ -12,6 +12,7 @@ import {
   RenderLeafProps,
   RenderPlaceholderProps,
 } from '../components/editable'
+import { SelectedContext } from './use-selected'
 
 /**
  * Children.
@@ -60,15 +61,17 @@ const useChildren = (props: {
 
     if (Element.isElement(n)) {
       children.push(
-        <ElementComponent
-          decorations={ds}
-          element={n}
-          key={key.id}
-          renderElement={renderElement}
-          renderPlaceholder={renderPlaceholder}
-          renderLeaf={renderLeaf}
-          selection={sel}
-        />
+        <SelectedContext.Provider value={!!sel}>
+          <ElementComponent
+            decorations={ds}
+            element={n}
+            key={key.id}
+            renderElement={renderElement}
+            renderPlaceholder={renderPlaceholder}
+            renderLeaf={renderLeaf}
+            selection={sel}
+          />
+        </SelectedContext.Provider>
       )
     } else {
       children.push(