Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention is not being deleted when focused #4330

Closed
golota60 opened this issue Jun 9, 2021 · 0 comments · Fixed by #4331
Closed

Mention is not being deleted when focused #4330

golota60 opened this issue Jun 9, 2021 · 0 comments · Fixed by #4331
Labels
bug ⚑ cross platform

Comments

@golota60
Copy link
Contributor

golota60 commented Jun 9, 2021 •
edited
Loading

Description

Focused mention is not being deleted when hitting backspace/delete button.

This is an extension of #3456 . The issue described there also happens on safari, but the PR that closed it fixes it only on Chrome

Recording

safari-mention-before

Sandbox
I think there's no need to add a sandbox link as it is fully reproducable in the hosted mention demo. https://www.slatejs.org/examples/mentions .

Steps
To reproduce the behavior:

  1. Open Safari
  2. Go to https://www.slatejs.org/examples/mentions
  3. Click on a mention(or focus on it using keyboard)
  4. Click delete/backspace
  5. Mention is not being deleted

Expectation
Mention should be deleted

Environment

  • Slate Version: v0.65.0
  • Operating System: macOS Catalina 10.15.7
  • Browser: Safari Version 14.0.3 (15610.4.3.1.7, 15610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ⚑ cross platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix deletion in safari when inline node is selected golota60/slate
1 participant
@golota60