Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix deletion in safari when inline node is selected #4331

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

golota60
Copy link
Contributor

@golota60 golota60 commented Jun 9, 2021

Description

This PR fixes the deletion of inline void nodes on Safari. It's basically an extension of #4307, so it applies also in Safari.

Issue
Fixes: #4330

Example
safari-mention-before
safari-mention-after

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2021

🦋 Changeset detected

Latest commit: 1ef3518

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clauderic clauderic self-requested a review June 9, 2021 15:43
Copy link
Collaborator

@clauderic clauderic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, this looks good 👍

@clauderic clauderic merged commit a3bc97a into ianstormtaylor:main Jun 9, 2021
@github-actions github-actions bot mentioned this pull request Jun 9, 2021
dylans pushed a commit to dylans/slate that referenced this pull request Sep 13, 2021
…4331)

Co-authored-by: Claudéric Demers <clauderic.d@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention is not being deleted when focused
2 participants