Fix handling of delete in Chrome when inline void node is selected #4307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes deletion of selected inline void nodes in Chrome. Chrome does not fire a
beforeinput
event when deleting backwards within an inline void node, so we need to add special logic to handle this edge-case for Chrome only.Both Firefox and Safari do not exhibit this behaviour, and fire the
deleteContentBackward
/deleteContentForward
beforeinput event when deleting backward/forward in a void inline node.Issue
Fixes: #3456
Example
Before.-.Delete.backward.in.inline.void.on.Chrome.mp4
Before.-.Delete.forward.in.inline.void.on.Chrome.mp4
After.-.Delete.backward.in.inline.void.on.Chrome.mp4
After.-.Delete.forward.in.inline.void.on.Chrome.mp4
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)