Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] Deletion of expanded range causes the editor to crash #4546

Closed
clauderic opened this issue Sep 24, 2021 · 2 comments · Fixed by #4549
Closed

[Firefox] Deletion of expanded range causes the editor to crash #4546

clauderic opened this issue Sep 24, 2021 · 2 comments · Fixed by #4549
Labels

Comments

@clauderic
Copy link
Collaborator

clauderic commented Sep 24, 2021

Description
There was a regression introduced in Firefox by #4529 which causes the editor to crash when deleting an expanded range that spans across more than a single node.

Recording

Firefox.expanded.selection.crash.mp4

Steps
To reproduce the behavior:

  1. Select an expanded range that spans across more than a single node
  2. Press deletet
  3. Editor crashes

Environment

  • Browser: Any version of Firefox (tested in Firefox 92, 91 and 90)
@clauderic clauderic added the bug label Sep 24, 2021
@nemanja-tosic
Copy link
Contributor

Introduced by #4529. Namely, i wanted to be smart and have only one event.preventDefault(), but missed an early return so it wasn't called for delete on an expanded selection. PR coming shortly.

@nemanja-tosic
Copy link
Contributor

@clauderic could you test #4549 please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants