Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deletion of expanded range #4549

Merged

Conversation

nemanja-tosic
Copy link
Contributor

@nemanja-tosic nemanja-tosic commented Sep 25, 2021

Context

In #4529, i wanted to have a single event.preventDefault() for the entire callback, but missed an early return. Here, I've put the preventDefault call back to where it was, and called it again from the onFlushed callback.

Issue
Fixes: #4546

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2021

🦋 Changeset detected

Latest commit: 5b1ebca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit f9c41a5 into ianstormtaylor:main Sep 26, 2021
@github-actions github-actions bot mentioned this pull request Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Firefox] Deletion of expanded range causes the editor to crash
2 participants