Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long press backspace #4714

Closed
YuriyMorkovnik opened this issue Dec 5, 2021 · 4 comments
Closed

Long press backspace #4714

YuriyMorkovnik opened this issue Dec 5, 2021 · 4 comments

Comments

@YuriyMorkovnik
Copy link

Description
Long press a backspace button causes a concatenation a part of deleting word. Also you can't hold a backspace to delete a part of a word because it stops you after the first symbol.

Recording

video_2021-12-05_10-26-41.mp4

Sandbox
There is just a copy of a official demo in sandbox
https://codesandbox.io/s/agitated-http-goi7b?file=/src/App.js

Steps
To reproduce the behavior:

  1. Write a text
  2. Hold a backspace button
  3. See error

Expectation
Smooth deleting of symbols while you’re holding a backspace button

Environment

  • Slate Version: 0.71
  • Operating System: Android 10
  • Browser: Chrome
@AkromDev
Copy link

AkromDev commented Dec 6, 2021

I had the same issue on galaxy s8 but did not face the issue on S21+ and galaxy A20. Maybe It seems that editor has some performance issues on slower/older phones and require more CPU/RAM power. I am not getting this issue anymore on latest examples. The backward delete seems to have been improved as well. My assumption is that #4706 has improved editor performance for android and some issues resulting from poor performance are now fixed.

@AkromDev
Copy link

AkromDev commented Dec 10, 2021

I noticed it is still happening in slate@0.71.0 with texts close to the images. But it improved compared to slate@0.71.0. Interesting thing is that it does not happen in their website but it happens when I clone the slate repo and run examples locally.

@TrySpace
Copy link

Seems related to this: #4715

@YuriyMorkovnik
Copy link
Author

Updated slate to v0.80. Seems this issue is fixed. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants