Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android restoreDOM to allow partial dom restoring #4706

Merged
merged 2 commits into from
Dec 4, 2021

Conversation

BitPhinix
Copy link
Contributor

@BitPhinix BitPhinix commented Dec 2, 2021

Description
The current android restoreDOM implementation always restores the entire editor. This has a drastic negative impact on editor performance.

Context
This PR updates the approach we are using to restore the dom to only include the minimal amount of nodes required for react to be able to reliably restore the dom to the desired state. It does so by listening for user-caused mutations, finding the closest know parent node, and only restoring mutated nodes on restoreDOM

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2021

🦋 Changeset detected

Latest commit: fe6cb29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BitPhinix BitPhinix force-pushed the android-partial-dom-restore branch from 2afa3b8 to 0415825 Compare December 2, 2021 10:37
Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BitPhinix !

@dylans dylans merged commit 6d19407 into ianstormtaylor:main Dec 4, 2021
@github-actions github-actions bot mentioned this pull request Dec 4, 2021
@thesunny
Copy link
Collaborator

thesunny commented Dec 6, 2021

Awesome @BitPhinix !

So good to see more updates on Android that I'm not involved in! Thank you so much for taking the time to dive into Android and contribute. The hope has always been to have more people understanding and working on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants