Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome legacy check is broken for v100+ #4869

Closed
GaurangTandon opened this issue Mar 7, 2022 · 1 comment · Fixed by #4883
Closed

Chrome legacy check is broken for v100+ #4869

GaurangTandon opened this issue Mar 7, 2022 · 1 comment · Fixed by #4883
Labels
bug ⚑ cross platform

Comments

@GaurangTandon
Copy link

GaurangTandon commented Mar 7, 2022 •
edited
Loading

Description

Chrome legacy check is broken for v100+.

Environment

  • Slate Version: any
  • Operating System: any
  • Browser: Chrome v100 beta that was released last week (Chrome Canary v101 also shows the bug)

Context

slate/packages/slate-react/src/utils/environment.ts

Line 31 in 8bc6a46

export const IS_CHROME_LEGACY =

Chrome 100 is marked as IS_CHROME_LEGACY = true, even though it is not a legacy browser.
@GaurangTandon
Copy link
Author

While fixing this bug, it would be a good idea to update legacy check for all browsers as they are updating to v100+ at the same time.

https://www.forbes.com/sites/gordonkelly/2022/02/19/google-chrome-microsoft-edge-mozilla-firefox-web-browser-update-warning

always-maap added a commit to always-maap/slate that referenced this issue Mar 11, 2022
@always-maap
fix chrome and edge three digit version check ianstormtaylor#4869
837e05f
@always-maap always-maap mentioned this issue Mar 11, 2022
Merged
5 tasks
dylans pushed a commit that referenced this issue Mar 14, 2022
@always-maap
Fix chrome and edge three digit version check (#4883)
3b3b0e3 
* fix chrome and edge three digit version check #4869

* add changelist
DougReeder pushed a commit to DougReeder/slate that referenced this issue Apr 3, 2022
@always-maap @DougReeder
Fix chrome and edge three digit version check (ianstormtaylor#4883)
ab689e3 
* fix chrome and edge three digit version check ianstormtaylor#4869

* add changelist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ⚑ cross platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix chrome and edge three digit version check always-maap/slate
1 participant
@GaurangTandon