Fix ios chrome ime double input issue. #4049
Conversation
|
Thanks @ulion! |
| @@ -613,7 +614,7 @@ export const Editable = (props: EditableProps) => { | |||
| // aren't correct and never fire the "insertFromComposition" | |||
| // type that we need. So instead, insert whenever a composition | |||
| // ends since it will already have been committed to the DOM. | |||
| if (!IS_SAFARI && !IS_FIREFOX && event.data) { | |||
| if (!IS_SAFARI && !IS_FIREFOX && !IS_IOS && event.data) { | |||
There was a problem hiding this comment.
This looks fine, but it's stale as we recently updated it to IS_FIREFOX_LEGACY. Could you do a quick rebase and then we can land this? Thanks @ulion!
ulion
force-pushed
the
hotfix/fix_ios_chrome_ime_double_input
branch
from
b7e4ac7 to
aba9997
Compare
🦋 Changeset detectedLatest commit: 29baeee The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
rebased
Dylan Schiemann ***@***.***> 于2021年8月4日周三 下午9:00写道：
… ***@***.**** requested changes on this pull request.
------------------------------
In packages/slate-react/src/components/editable.tsx
<#4049 (comment)>:
> @@ -613,7 +614,7 @@ export const Editable = (props: EditableProps) => {
// aren't correct and never fire the "insertFromComposition"
// type that we need. So instead, insert whenever a composition
// ends since it will already have been committed to the DOM.
- if (!IS_SAFARI && !IS_FIREFOX && event.data) {
+ if (!IS_SAFARI && !IS_FIREFOX && !IS_IOS && event.data) {
This looks fine, but it's stale as we recently updated it to
IS_FIREFOX_LEGACY. Could you do a quick rebase and then we can land this?
Thanks @ulion <https://github.com/ulion>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4049 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABKYHKKPQHZQJPKVYMDSJLT3E2VFANCNFSM4WIYZH5A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
Thanks @ulion, I'm making a push to land obvious PRs asap, so I hope to get this merged very soon. |
|
@ulion This one was missing a changeset so I've added a PR on your branch. If you don't mind please accept and push into this PR and then I'll land it. |
add changeset
|
@ulion sorry about the prettier issue, if you can please run |
done both. |
* Fix ios chrome ime double input issue. * add changeset * pretty fix. Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org> Thanks @ulion!
Is this adding or improving a feature or fixing a bug?
Fix a bug
What's the new behavior?
IME input won't duplicate.
How does this change work?
IOS chrome looks just fine, so no need special code on compositionEnd to insertData.
Have you checked that...?
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)Does this fix any issues or need any specific reviewers?
Fixes: #
Reviewers: @