Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename data-slate-editor to not interfere with data-gramm #4126

Conversation

koralarts
Copy link

Rename data-slate-editor to data-slate-react-editor because it inteferes with the data-gramm attribute which should disable the Grammarly extension

Description
When the Grammarly extension is installed, it does not get disabled even if data-gramm is set to false.

Issue
Fixes: #4124

Example

Default:
Screen Shot 2021-03-16 at 2 55 30 PM

When data-gramm={undefined}:
Screen Shot 2021-03-16 at 2 55 07 PM

Context
The issue stems from data-slate-editor which seems to interfere with Grammarly's logic to determine whether the extension is enabled or disabled for an editor.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)

…feres with the data-gramm attribute which should disable the Grammarly extension
@clauderic
Copy link
Collaborator

@koralarts it sounds like the developers at Grammarly intentionally added data-slate-editor to a list of elements where the extension should not be applied, presumably because of issues at the time (which may or may not still be relevant today).

Based on that, I don't think renaming data-slate-editor to data-slate-react-editor is the right solution. Rather, you should try to get in touch with the development team at Grammarly to inquire about why they made that decision.

@koralarts
Copy link
Author

@clauderic Ok. I'll contact them. Thanks.

@koralarts koralarts closed this Mar 18, 2021
williamstein added a commit to sagemathinc/cocalc that referenced this pull request Mar 18, 2021
…icitly ignore it and grammarly works well with slate (as far as I can tell). See discussion at ianstormtaylor/slate#4126
@ianstormtaylor
Copy link
Owner

@koralarts do you have an update here?

@koralarts
Copy link
Author

@ianstormtaylor No update yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data-gramm not actually disabling Grammarly
3 participants