fix(slate-react): use Text.equals to compare leaf

[gyh9457]

Description
fix MenoizedLeaf function

Issue

Example

  prev: { text: 'a' }
  next: { text: 'a', highlight: true }

  matches(text: Text, props: Partial<Text>): boolean {
    for (const key in props) {
      if (key === 'text') {
        continue
      }

      if (!text.hasOwnProperty(key) || text[key] !== props[key]) {
        return false
      }
    }

    return true
  },

  Text.matches(next.leaf, prev.leaf) // compare

  // in the matches function ,props do not include `highlight`. so it return true. but in fact ,it should return false

Checks

• The new code matches the existing patterns and styles.
• The tests pass with yarn test.
• The linter passes with yarn lint. (Fix errors with yarn fix.)
• The relevant examples still work. (Run examples with yarn start.)
• You've added a changeset if changing functionality. (Add one with yarn changeset add.)

[changeset-bot]

🦋 Changeset detected

Latest commit: 9338c95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
slate-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ianstormtaylor]

Great catch @gyh9457! Would it be possible to remove the previous line now (and the loose option) to simplify the logic even further. Instead of:

     next.text === prev.text &&
     next.leaf.text === prev.leaf.text &&
     Text.equals(prev.leaf, next.leaf, { loose: true }) &&

We'd have:

     next.text === prev.text &&
     Text.equals(prev.leaf, next.leaf) &&

[gyh9457]

done @ianstormtaylor

[dylans]

Part of this was handled in #4347.

Need to decide if we can safely also remove next.leaf.text === prev.leaf.text &&