Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key for Children SelectedContext.Provider #4480

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

imdbsd
Copy link
Contributor

@imdbsd imdbsd commented Aug 31, 2021

Description
Adding key for SelectedContext.Provider in Children to remove warning from react in development mode.

Issue
Fixes: #4464

Example
Screen Shot 2021-08-31 at 11 29 17

Screen Shot 2021-08-31 at 11 31 18

Context
key will be provider- followed by children id. example provider-0

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2021

🦋 Changeset detected

Latest commit: 7d6c14c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@imdbsd
Copy link
Contributor Author

imdbsd commented Aug 31, 2021

the test run fine on my local

Screen Shot 2021-08-31 at 12 53 38

@dylans dylans merged commit e51566a into ianstormtaylor:main Aug 31, 2021
@dylans dylans mentioned this pull request Sep 11, 2021
dylans pushed a commit to dylans/slate that referenced this pull request Sep 13, 2021
* Add key for Children context

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: Each child in a list should have a unique "key" prop
2 participants