Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to disable Grammarly in Slate #4650

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

e1himself
Copy link
Contributor

@e1himself e1himself commented Nov 9, 2021

Description

Stop trying to disable Grammarly extension from working in Slate editors.

Issue
Fixes: #4124

Example

Peek 2021-11-09 18-19

Context

The Grammarly extension is not causing DOM issues anymore, as they have reworked their highlighting logic:
https://www.grammarly.com/blog/engineering/making-grammarly-feel-native-on-every-website/

Also the data-gramm attribute (introduced in #733) is no longer working actually (see #4124), as the Grammarly team changed the name.

Though applying Grammarly suggestions is still broken: #4579 (but it does not break the editor, so it may be fine).

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

As the `data-gramm` attribute is no longer working actually. See ianstormtaylor#4124 

The Grammarly extension is not causing the DOM issues anymore, as they have reworked their highlighting logic: 
https://www.grammarly.com/blog/engineering/making-grammarly-feel-native-on-every-website/
@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2021

🦋 Changeset detected

Latest commit: 6ea4ae6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it does look Grammarly has resolved the issues with their approach.

@dylans dylans merged commit b664313 into ianstormtaylor:main Nov 9, 2021
@github-actions github-actions bot mentioned this pull request Nov 9, 2021
@e1himself e1himself deleted the patch-1 branch November 10, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data-gramm not actually disabling Grammarly
2 participants