Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: weak guard on DataTransfer to not rely on current window #4654

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

anho
Copy link
Contributor

@anho anho commented Nov 11, 2021

Description
As previously asked in Slack, this helps in automated testing where it's currently not possible to properly transfer data between the host app and the application under test. The previous instanceof window.DataTransfer fails as Cypress is not able to properly get hold of the window object Slate is referring to (despite using cy.window). To mitigate that the check is now checking for the constructor name.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2021

🦋 Changeset detected

Latest commit: d7834fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit 2c7750c into ianstormtaylor:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants