Avoid transforming dirty paths if the op won't touch them #4735
Conversation
🦋 Changeset detectedLatest commit: 1d22cb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/slate/src/create-editor.ts
Outdated
| for (const path of oldDirtyPaths) { | ||
| const newPath = Path.transform(path, op) | ||
| add(newPath) | ||
| if (canTransformPath) { |
There was a problem hiding this comment.
I was hoping we could optimize this more but I realized we have to rebuild the set for de-duping each time. Maybe the key set should be persisted with the DIRTY_PATHS so this doesn't need to be reconstructed each time. This code path can be so hot on large edits.
There was a problem hiding this comment.
I can investigate storing the path keys alongside the dirty paths and seeing what additional savings we can get
There was a problem hiding this comment.
Updated to reuse the array/set entirely if the op won't touch them. Shaved an additional ~10% of time off the test mentioned in the summary
steve-codaio
force-pushed
the
sgm-transform-path
branch
from
432784d to
1d22cb8
Compare
…ylor#4735) * Avoid transforming dirty paths if the op won't touch them * Avoid the loop entirely if op doesn't affect path
Description
While large bulk edits are not a common scenario, we noticed that the dirty path tracking during batches has an O(n^2) behavior in relation to the number of ops. This is because as every op gets applied, we loop over all previous dirty paths and transform them. This implements an optimization where we can bypass the no-op transform entirely if we know the op won't affect paths at all.
In a simple test where I had a slate with 1000 texts and I applied an 'insert_text' op appending a character to each text, I saw about a 50% time savings (went from ~2s down to ~1s)
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)