Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to reflect Slate is an uncontrolled component #4768

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Update docs to reflect Slate is an uncontrolled component #4768

merged 3 commits into from
Jan 10, 2022

Conversation

antsago
Copy link
Contributor

@antsago antsago commented Jan 5, 2022 •
edited
Loading

Description
Updated docs to explain that Slate provider is now an uncontrolled component, to match the changes introduced in this pr: #4540. Thanks to @KarimNahas for his resetNodes example

Issue
Fixes: #4765

Example
N/A

Context
N/A

Checks

  • This is a pure docs change

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f75127

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@antsago antsago changed the title Updated documentation Update docs to reflect Slate is an uncontrolled component Jan 5, 2022
dylans
dylans requested changes Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion as I loathe linking to the word here. Thanks @antsago for taking the time to contribute this update!

antsago and others added 2 commits January 5, 2022 14:23
@antsago @dylans
Update docs/walkthroughs/01-installing-slate.md
7d03741 
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
@antsago
fix: formatting errors
9f75127
@antsago antsago requested a review from dylans January 5, 2022 13:31
@antsago
Copy link
Contributor Author

antsago commented Jan 5, 2022

Good suggestion! Thanks to yourself and @ianstormtaylor for sharing this library with everyone :D

@dylans dylans merged commit 51e02de into ianstormtaylor:main Jan 10, 2022
This was referenced Jan 20, 2022
Open
Closed
DougReeder pushed a commit to DougReeder/slate that referenced this pull request Apr 3, 2022
@antsago @dylans @DougReeder
Update docs to reflect Slate is an uncontrolled component (ianstormta…
3afbb6f 
…ylor#4768)

* Updated documentation

* Update docs/walkthroughs/01-installing-slate.md

Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>

* fix: formatting errors

Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylans dylans dylans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slate-react is an uncontrolled component in v0.67+
2 participants
@antsago @dylans