Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show example of a workaround for Chrome bug that puts cursor in wrong place #4772

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Show example of a workaround for Chrome bug that puts cursor in wrong place #4772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion site/examples/inlines.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,16 @@ const initialValue: Descendant[] = [
children: [
{
text:
'There are two ways to add links. You can either add a link via the toolbar icon above, or if you want in on a little secret, copy a URL to your keyboard and paste it while a range of text is selected.',
'There are two ways to add links. You can either add a link via the toolbar icon above, or if you want in on a little secret, copy a URL to your keyboard and paste it while a range of text is selected. ',
},
// The following is an example of an inline at the end of a block.
// This is an edge case that can cause issues.
{
type: 'link',
url: 'https://twitter.com/JustMissEmma/status/1448679899531726852',
children: [{ text: 'Finally, here is our favorite dog video.' }],
},
{ text: '' },
],
},
]
Expand Down Expand Up @@ -96,6 +104,7 @@ const InlinesExample = () => {
</Toolbar>
<Editable
renderElement={props => <Element {...props} />}
renderLeaf={props => <Text {...props} />}
placeholder="Enter some text..."
onKeyDown={onKeyDown}
/>
Expand Down Expand Up @@ -291,6 +300,29 @@ const Element = props => {
}
}

const Text = props => {
const { attributes, children, leaf } = props
return (
<span
// The following is a workaround for a Chromium bug where,
// if you have an inline at the end of a block,
// clicking the end of a block puts the cursor inside the inline
// instead of inside the final {text: ''} node
// https://github.com/ianstormtaylor/slate/issues/4704#issuecomment-1006696364
className={
leaf.text === ''
? css`
padding-left: 0.1px;
`
: null
}
{...attributes}
>
{children}
</span>
)
}

const AddLinkButton = () => {
const editor = useSlate()
return (
Expand Down