Fix text content not rendered on ssr #4798
Merged
+20
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix makes sure that the text content of the TextString component is rendered on the first render.
Issue
Fixes: server-side rendering issue introduced by #4733.
Correct fix of #4796.
Example
Please see example in #4796.
Context
#4733 spellcheck fix changed the render behavior of the TextString component. TextString won't render the actual text content on the first-time render, which means server-side rendering is broken. This fix ensures that the text content will get rendered immediately on the first-time render.
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)