Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toSlatePoint suppressThrow leaf without text node #4813

Conversation

BitPhinix
Copy link
Contributor

Description
toSlatePoint throws while using suppressThrow if the selection is inside a node with a data-slate-leaf attribute with no text child (due to calling range.setStart with textNode being null). This can happen when e.g. rendering a slate 0.47 editor inside a void element.

This pr adds a simple check to see if textNode is set.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2022

🦋 Changeset detected

Latest commit: 0ef59a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BitPhinix
Copy link
Contributor Author

Ci passes locally

@dylans dylans merged commit a5fd62d into ianstormtaylor:main Jan 28, 2022
@github-actions github-actions bot mentioned this pull request Jan 28, 2022
DougReeder pushed a commit to DougReeder/slate that referenced this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants