Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix not update state when unmounted #4819

Merged
merged 2 commits into from
Feb 5, 2022
Merged

fix not update state when unmounted #4819

merged 2 commits into from
Feb 5, 2022

Conversation

ugaya40
Copy link
Contributor

@ugaya40 ugaya40 commented Feb 4, 2022 •
edited
Loading

Description
Changed so that the state of the slate component is not updated when unmounting.

Issue
Fixes: #4818

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 89719e5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dylans
dylans approved these changes Feb 4, 2022
View reviewed changes
Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks reasonable. Will land it once the tests pass.

dylans
dylans reviewed Feb 5, 2022
View reviewed changes
Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok just needs a change set and then we can land this.

@ugaya40
Copy link
Contributor Author

ugaya40 commented Feb 5, 2022 •
edited
Loading

I'll try.

@ugaya40 ugaya40 closed this Feb 5, 2022
@ugaya40 ugaya40 reopened this Feb 5, 2022
@ugaya40
Copy link
Contributor Author

ugaya40 commented Feb 5, 2022

Added changeset.

@dylans dylans merged commit 8066150 into ianstormtaylor:main Feb 5, 2022
@github-actions github-actions bot mentioned this pull request Feb 5, 2022
Merged
@ugaya40 ugaya40 deleted the fix#4818 branch February 5, 2022 16:03
@github-actions github-actions bot mentioned this pull request Feb 10, 2022
Open
DougReeder pushed a commit to DougReeder/slate that referenced this pull request Apr 3, 2022
@ugaya40 @DougReeder
fix not update state when unmounted (ianstormtaylor#4819)
f09bce7 
* fix not update state when unmounted

* add changeset
e1himself added a commit to e1himself/slate that referenced this pull request Sep 14, 2023
@e1himself
Drop a leftover useRef() call
26b448b 
It was first introduced in ianstormtaylor#4819
but then the usage of this ref was removed with ianstormtaylor#4874

So the ref remained unused since then.
@e1himself e1himself mentioned this pull request Sep 14, 2023
Merged
5 tasks
dylans pushed a commit that referenced this pull request Sep 18, 2023
@e1himself
Drop a leftover useRef() call (#5510)
13c7d27 
* Drop a leftover `useRef()` call

It was first introduced in #4819
but then the usage of this ref was removed with #4874

So the ref remained unused since then.

* Add a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylans dylans dylans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State update occurs when unmounting
2 participants
@ugaya40 @dylans