fix isDraggingInternally reset logic #4828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
isDraggingInternally
is only reset if theonDrop
/onDragEnd
events aren't handled by the respective "external" editable event handlers. This potentially causesisDraggingInternally
to staytrue
even though the user isn't dragging anymore blockingonDOMSelectionChange
thus preventing the user from selecting anything inside the editor.Context
This pr simply ensues
isDraggingInternally
is always resetonDrop
/onDragEnd
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)