Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isDraggingInternally reset logic #4828

Merged

Conversation

BitPhinix
Copy link
Contributor

Description
Currently isDraggingInternally is only reset if the onDrop/onDragEnd events aren't handled by the respective "external" editable event handlers. This potentially causes isDraggingInternally to stay true even though the user isn't dragging anymore blocking onDOMSelectionChange thus preventing the user from selecting anything inside the editor.

Context
This pr simply ensues isDraggingInternally is always reset onDrop/onDragEnd

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2022

🦋 Changeset detected

Latest commit: f8a2d9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit d5ac823 into ianstormtaylor:main Feb 11, 2022
@github-actions github-actions bot mentioned this pull request Feb 11, 2022
DougReeder pushed a commit to DougReeder/slate that referenced this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants