Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render void spacer in readonly mode #4840

Merged

Conversation

BitPhinix
Copy link
Contributor

@BitPhinix BitPhinix commented Feb 15, 2022

Description
Currently finding the dom range of a void node in read-only crashes the editor since slate doesn't render the void spacer in read-only.

This pr simply adjusts the Element component so that it is rendered even in read-only.

⚠️ I'm not sure why this wasn't the case before, so there might be something I'm missing here.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2022

🦋 Changeset detected

Latest commit: 21ab7c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans
Copy link
Collaborator

dylans commented Feb 17, 2022

I'm not sure why this wasn't the case before, so there might be something I'm missing here.

I'm guessing oversight rather than intentional. I'll land this now, thanks.

@dylans dylans merged commit 100448d into ianstormtaylor:main Feb 17, 2022
@github-actions github-actions bot mentioned this pull request Feb 17, 2022
DougReeder pushed a commit to DougReeder/slate that referenced this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants