Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor root triple click crash #4944

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

BitPhinix
Copy link
Contributor

@BitPhinix BitPhinix commented Apr 13, 2022

Description
Fixes a regression introduced by #4933. Basically, when triple-clicking the editor root, the path has a length of 0 so it was calling Editor.start,Editor.end with a path of [undefined].

This pr also moved some in-place checks for the later handling before the manual triple-click handling to ensure we are acting on a valid state.

Issue
Fixes: #4941

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2022

🦋 Changeset detected

Latest commit: 58cb881

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit 486c385 into ianstormtaylor:main Apr 13, 2022
@github-actions github-actions bot mentioned this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slate sample code got an error with double or triple click
2 participants